perf-tests icon indicating copy to clipboard operation
perf-tests copied to clipboard

Refactor wait_for_{pods, pvcs, pvc} and {pods, pvcs, pvs} files

Open wojtek-t opened this issue 6 years ago • 4 comments

We're accumulating a lot of code duplication for different types:

  • pods: https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/util/pods.go https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/common/wait_for_pods.go
  • pvcs https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/util/pvcs.go https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/common/wait_for_pvcs.go
  • pvs https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/util/pvs.go https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/common/wait_for_pvs.go

Those should be refactor to share as much code as possible

wojtek-t avatar Aug 01 '19 19:08 wojtek-t

How I would see that:

  • the files from /util directory should implement some interfaces (Diff, ComputeStatus, etc.)
  • the wait_for-* should simply take the interface and use that (this one should hopefully be possible to implement just once and not even have any customizations for)

wojtek-t avatar Aug 01 '19 19:08 wojtek-t

@krzysied - FYI

wojtek-t avatar Aug 01 '19 19:08 wojtek-t

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Oct 30 '19 19:10 fejta-bot

/remove-lifecycle stale /lifecycle frozen

wojtek-t avatar Oct 31 '19 08:10 wojtek-t