perf-tests icon indicating copy to clipboard operation
perf-tests copied to clipboard

Feature addition to network benchmark tests

Open ritwikranjan opened this issue 1 year ago • 10 comments

What would you like to be added: I was looking into the network benchmarking tests available under /network/benchmarks/netperf. The tests present there are pretty old and very restrictive in how we study and publish them. Adding new test is not very trivial and there are a lot of conditionals involved. I was thinking of cleaning the way these network tests are written and also add additional output options like json which can be used to save and publish much more information than it do currently.

Why is this needed: This will make the tests more useful, easy to change, and more developer-friendly.

ritwikranjan avatar Sep 09 '24 19:09 ritwikranjan

@ritwikranjan I will happy to review a new proposal, a google doc or something similar can work

aojea avatar Sep 09 '24 20:09 aojea

Sounds great, I will write a proposal and send it here!

ritwikranjan avatar Sep 09 '24 20:09 ritwikranjan

Hey @aojea, please find the doc attached, if it looks good I'll start working on a PR. proposal_perf_tests.docx

ritwikranjan avatar Sep 11 '24 19:09 ritwikranjan

I have created a PR for first of a few changes I am planning to do on my fork. Feel free to take a look and suggest changes and improvements.

https://github.com/ritwikranjan/perf-tests/pull/1

I will make all the changes on my fork and open an upstream PR.

ritwikranjan avatar Sep 14 '24 12:09 ritwikranjan

Bumping up the thread, Hey @aojea did you had the chance to take a look at the proposal?

ritwikranjan avatar Oct 30 '24 11:10 ritwikranjan

Bumping up the thread, Hey @aojea did you had the chance to take a look at the proposal?

can you put the proposal in a shareable format? google docs, hackcmd or even a PR should be valid,

aojea avatar Oct 30 '24 12:10 aojea

I have opened a PR #2969 with majority of the changes I have put in the proposal and I am going to make the proposal document in an online format as well. Let me know if this link works: https://1drv.ms/w/s!AlRV0Mo2jG1lg6RkJp4NRLNw9IOZNg?e=H7Fhdd, otherwise I will port it to google docs!

ritwikranjan avatar Oct 30 '24 15:10 ritwikranjan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 28 '25 16:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 27 '25 16:02 k8s-triage-robot

/remove-lifecycle rotten

I am working on it, got busy recently but will resume as soon as I can.

ritwikranjan avatar Feb 27 '25 17:02 ritwikranjan

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 28 '25 18:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 27 '25 18:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jul 27 '25 18:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 27 '25 18:07 k8s-ci-robot