perf-tests
perf-tests copied to clipboard
kubernetes
[WIP] build(deps): bump k8s.io/kubernetes from 1.29.7 to 1.30.4 in /clusterloader2
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumps k8s.io/kubernetes from 1.29.7 to 1.30.4
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
/retitle [WIP] build(deps): bump k8s.io/kubernetes from 1.29.7 to 1.30.4 in /clusterloader2
Once component-base is updated, this failure begins happening in unit tests for clusterloader2:
? k8s.io/perf-tests/clusterloader2/pkg/measurement/common/network-policy [no test files]
? k8s.io/perf-tests/clusterloader2/pkg/measurement/common/probes [no test files]
/tmp/go-build2416630747/b1424/common.test flag redefined: v
panic: /tmp/go-build2416630747/b1424/common.test flag redefined: v
goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0001780e0, {0x2925e40, 0x3e3a170}, {0x29117d8, 0x1}, {0x2594931, 0x22})
/usr/local/go/src/flag/flag.go:1028 +0x37d
k8s.io/component-base/logs.AddGoFlags.func1(0xc000599180?)
/home/prow/go/pkg/mod/k8s.io/[email protected]/logs/logs.go:135 +0x130
flag.(*FlagSet).VisitAll(0x0?, 0xc000697dc0)
/usr/local/go/src/flag/flag.go:458 +0x42
k8s.io/component-base/logs.AddGoFlags(0xc0001780e0, {0x0, 0x0, 0x2d?})
/home/prow/go/pkg/mod/k8s.io/[email protected]/logs/logs.go:121 +0xa5
k8s.io/component-base/logs/testinit.init.0()
/home/prow/go/pkg/mod/k8s.io/[email protected]/logs/testinit/testinit.go:31 +0x25
FAIL k8s.io/perf-tests/clusterloader2/pkg/measurement/common 0.192s
I'm at a loss to work around it. A command-line flag is being registered twice, which panics. According to the component-base code, there is an option to ignore log flag settings, which presumably would avoid this problem. But I can't see how to configure that at package load time.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mboersma Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-perf-tests-verify-test | 740953d625bb652c4a861ade3acb1f74c121db5c | link | true | /test pull-perf-tests-verify-test |
| pull-perf-tests-clusterloader2 | 740953d625bb652c4a861ade3acb1f74c121db5c | link | true | /test pull-perf-tests-clusterloader2 |
| pull-perf-tests-clusterloader2-kubemark | 740953d625bb652c4a861ade3acb1f74c121db5c | link | true | /test pull-perf-tests-clusterloader2-kubemark |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
FYI - I'm figuring out the failures in https://github.com/kubernetes/perf-tests/pull/3050
I managed to pass the tests, and these are slowly merging, so closing this one.