perf-tests icon indicating copy to clipboard operation
perf-tests copied to clipboard

Add option to load perf dash metrics from local artifacts directory

Open Jont828 opened this issue 1 year ago • 6 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds an additional metrics bucket type called local which allows users to load perf dash metrics from a local directory, specifically the output from running clusterloader2 with the --reportdir flag set. This is primarily used for development purposes so perf dash is usable with job data that is not hosted on prow.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Jont828 avatar Aug 09 '24 01:08 Jont828

/retest

/home/prow/go/pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/exec.go:35:2: golang.org/x/[email protected]: read "https://proxy.golang.org/golang.org/x/crypto/@v/v0.0.0-20190308221718-c2843e01d9a2.zip": stream error: stream ID 31; INTERNAL_ERROR; received from peer

Seems like a network flake? Edit: yep.

mboersma avatar Aug 09 '24 17:08 mboersma

/hold

This still needs the commits squashed and may be WIP.

mboersma avatar Aug 09 '24 19:08 mboersma

/hold cancel

Jont828 avatar Aug 13 '24 22:08 Jont828

@mboersma Squashed and should be good to go.

Jont828 avatar Aug 13 '24 22:08 Jont828

looks good, thanks for the contribution. I guess that code-workspace file was accidentally added?

marseel avatar Sep 17 '24 08:09 marseel

Thank you! /lgtm /approve

marseel avatar Oct 04 '24 10:10 marseel

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, marseel, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 04 '24 10:10 k8s-ci-robot