perf-tests icon indicating copy to clipboard operation
perf-tests copied to clipboard

New Tuning Set: Adding a Poisson tuning set

Open dumb0002 opened this issue 1 year ago • 6 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a Poisson tuningSet - it will allow to generate load using a Poisson distribution

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

dumb0002 avatar Apr 04 '24 03:04 dumb0002

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: dumb0002 / name: Braulio Dumba (d973dd0b743e4dfa4426ea855185562ecc51c347)

Hi @dumb0002. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 04 '24 03:04 k8s-ci-robot

/ok-to-test

marseel avatar Apr 15 '24 10:04 marseel

@dumb0002 Take a look at two failing tests please, one is failing due to:

Boilerplate header is wrong for: /home/prow/go/src/k8s.io/perf-tests/clusterloader2/pkg/tuningset/poisson_load.go

The other is failing due to:

pkg/tuningset/poisson_load.go:61: File is not `gofmt`-ed with `-s` (gofmt)

marseel avatar Apr 17 '24 09:04 marseel

@marseel, fixed - all the tests are succeeding now

dumb0002 avatar Apr 17 '24 18:04 dumb0002

looks great, thanks /lgtm /approve

marseel avatar May 14 '24 10:05 marseel

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dumb0002, marseel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 14 '24 10:05 k8s-ci-robot