perf-tests icon indicating copy to clipboard operation
perf-tests copied to clipboard

config: add a new measurement to watchlist job type

Open p0lyn0mial opened this issue 2 years ago • 6 comments

WatchListLatencyPrometheus measurement gathers 50th, 90th and 99th duration quantiles for watch list requests broken down by group, resource, scope.

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds WatchListLatencyPrometheus measurement to watchlist job type. The new measurement gathers 50th, 90th and 99th duration quantiles for watch list requests broken down by group, resource, scope.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The new measurement was added in https://github.com/kubernetes/perf-tests/pull/2315

xref: https://github.com/kubernetes/enhancements/issues/3157

p0lyn0mial avatar Sep 12 '23 08:09 p0lyn0mial

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p0lyn0mial Once this PR has been reviewed and has the lgtm label, please assign mborsz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 12 '23 08:09 k8s-ci-robot

/hold

we should merge https://github.com/kubernetes/perf-tests/pull/2315 first.

p0lyn0mial avatar Sep 12 '23 08:09 p0lyn0mial

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 21 '24 13:01 k8s-triage-robot

/remove-lifecycle stale

p0lyn0mial avatar Jan 29 '24 09:01 p0lyn0mial

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 28 '24 10:04 k8s-triage-robot

/remove-lifecycle stale

p0lyn0mial avatar May 21 '24 07:05 p0lyn0mial

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 19 '24 08:08 k8s-triage-robot

I think we can close this PR because watch-list latency was added to APIResponsivenessPrometheus in https://github.com/kubernetes/perf-tests/pull/2764

/close

p0lyn0mial avatar Aug 20 '24 07:08 p0lyn0mial

@p0lyn0mial: Closed this PR.

In response to this:

I think we can close this PR because watch-list latency was added to APIResponsivenessPrometheus in https://github.com/kubernetes/perf-tests/pull/2764

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 20 '24 07:08 k8s-ci-robot