org icon indicating copy to clipboard operation
org copied to clipboard

Update admins and maintainers of KMM

Open qbarrand opened this issue 3 years ago • 1 comments
trafficstars

Remove zvonkok and adrianchiris who contributed to SRO but not to KMM. Set qbarrand and yevgeny-shnaidman who are the main KMM contributors.

qbarrand avatar Oct 27 '22 12:10 qbarrand

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qbarrand Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval by writing /assign @derekwaynecarr in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 27 '22 12:10 k8s-ci-robot

@adrianchiris @zvonkok any objections? If not, please lgtm.

bart0sh avatar Dec 23 '22 09:12 bart0sh

/assign @adrianchiris @zvonkok

bart0sh avatar Dec 23 '22 09:12 bart0sh

lgtm, no objections on my end.

adrianchiris avatar Dec 26 '22 07:12 adrianchiris

/lgtm /assign @derekwaynecarr @dchen1107 @mrunalp

bart0sh avatar Jan 06 '23 06:01 bart0sh

@dchen1107 @derekwaynecarr is everything fine with this change?

iranzo avatar Jan 19 '23 10:01 iranzo

/approve

derekwaynecarr avatar Jan 31 '23 21:01 derekwaynecarr

/hold

derekwaynecarr avatar Jan 31 '23 21:01 derekwaynecarr

in case I missed a discussion, is there any discussion on this change from a sig meeting or other setting that you can link to or is it possible for the names being removed to agree with the change?

derekwaynecarr avatar Jan 31 '23 21:01 derekwaynecarr

/lgtm /approve

dchen1107 avatar Feb 07 '23 18:02 dchen1107

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, derekwaynecarr, mrunalp, qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 07 '23 18:02 k8s-ci-robot

once concern I have is that this change make both contributors be from the same company. I don't think this should block the PR, but I strongly suggest to seek for maintainers from other company.

SergeyKanzhelev avatar Feb 07 '23 18:02 SergeyKanzhelev

@derekwaynecarr this was agreed to at Feb 7th sig-node meeting. Names removed were there for historical reasons (SRO -> KMM) but are not KMM contributors. OK to /unhold?

qbarrand avatar Feb 09 '23 10:02 qbarrand

/hold cancel

derekwaynecarr avatar Mar 07 '23 18:03 derekwaynecarr