org icon indicating copy to clipboard operation
org copied to clipboard

add nilekhc and salaxander to secrets-store-csi-driver maintainers

Open aramase opened this issue 2 years ago • 10 comments

Signed-off-by: Anish Ramasekar [email protected]

/assign @tam7t @ritazh /cc @nilekhc @salaxander

aramase avatar Jun 29 '22 20:06 aramase

@aramase: GitHub didn't allow me to request PR reviews from the following users: nilekhc.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: Anish Ramasekar [email protected]

/assign @tam7t @ritazh /cc @nilekhc @salaxander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 29 '22 20:06 k8s-ci-robot

/hold

for reviews

aramase avatar Jun 29 '22 20:06 aramase

+1

ritazh avatar Jun 29 '22 20:06 ritazh

/lgtm :)

salaxander avatar Jun 29 '22 21:06 salaxander

/lgtm /approve

@ritazh's +1 should be sufficient here since @ritazh is in sig-auth-leads

https://github.com/kubernetes/org/blob/b98f9b1029b8e5adabec7c08713bd8c7f20cf72a/OWNERS_ALIASES#L14-L19

PS: Changes to files inside config/<org>/<sig> don't require approval from GitHub Admins. The OWNERS in those directories can themselves LGTM and Approve.

palnabarun avatar Jul 28 '22 14:07 palnabarun

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 28 '22 14:07 k8s-ci-robot

@aramase @ritazh Please feel to remove the hold whenever you want. :)

palnabarun avatar Jul 28 '22 14:07 palnabarun

thanks @palnabarun! We're also going to discuss in the secrets-store-csi-driver community call next week. I'll remove the /hold if there are no concerns after that.

aramase avatar Jul 28 '22 16:07 aramase

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 26 '22 16:10 k8s-triage-robot

/remove-lifecycle stale /cc @tam7t

aramase avatar Oct 26 '22 16:10 aramase

Is there a reason the hold is still in place? Can this be merged?

mrbobbytables avatar Nov 22 '22 15:11 mrbobbytables

Is there a reason the hold is still in place? Can this be merged?

@mrbobbytables We're waiting for consensus from the community meeting. I'll post an update here after our next call on Decemeber 8th.

aramase avatar Nov 22 '22 19:11 aramase

/lgtm

tam7t avatar Jan 05 '23 16:01 tam7t

/unhold

salaxander avatar Jan 05 '23 16:01 salaxander