node-problem-detector
node-problem-detector copied to clipboard
kubernetes
Move ReadonlyFilesystem Node Condition to a new configuration file
We're enhancing NPD to support detection of various read-only scenarios (e.g., boot disk, local SSDs, network-attached drives). To support this, the ReadonlyFilesystem configuration is being moved from the kernel monitor into a dedicated plugin configuration file that will take over this new functionality.
Welcome @DigitalVeer!
It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/node-problem-detector has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @DigitalVeer. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
You need to add your new plugin config file to https://github.com/kubernetes/node-problem-detector/blob/dc4200d805c9554d6585dba8d1a566fb20b6869b/config/systemd/node-problem-detector-metric-only.service#L11 (and potentially other files).
To make sure it is backward compatible for people using the OSS config file directly, we need to add the new file to all the locations where kernel-monitor.json is invoked: https://github.com/search?q=repo%3Akubernetes%2Fnode-problem-detector%20kernel-monitor.json&type=code
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: DigitalVeer, hakman, mmiranda96, wangzhen127
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [wangzhen127]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@wangzhen127 There's a problem with the failing tests. Seems to be something broken in some other related repo. Any ideas?