node-problem-detector icon indicating copy to clipboard operation
node-problem-detector copied to clipboard

[StepSecurity] Apply security best practices

Open sozercan opened this issue 1 year ago • 4 comments

Hey folks,

This is originally generated by https://app.stepsecurity.io/securerepo and I updated with a few changes https://github.com/sozercan/node-problem-detector/pull/1

What this PR does:

  • Adds dependabot with a weekly cadence with grouping for GHA and k8s deps to bump various dependencies like gomod, docker etc, to make lives of maintainers easier
  • introduces codeql, openssf scorecard and dependency review to improve supply chain security
  • pins existing GHA to improve security. these dependencies will still automatically get bumped by dependabot
  • adds harden runner with an audit policy. this will surface network endpoints used by the CI. and in the future, you can change this to deny to enable network isolation for improved security
  • sets least amount of permissions to existing workflows
  • adds optional pre-commit hooks to shift left to prevent any cred leaks, linting, etc
  • pins golang builder image to a digest. this will still automatically get bumped by dependabot
  • remove baseimage docker var, since the image won't be able to get bumped automatically with that

sozercan avatar May 17 '24 21:05 sozercan

Welcome @sozercan!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar May 17 '24 21:05 k8s-ci-robot

Hi @sozercan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 17 '24 21:05 k8s-ci-robot

/ok-to-test

hakman avatar May 18 '24 06:05 hakman

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 16 '24 07:08 k8s-triage-robot

/remove-lifecycle stale

hakman avatar Aug 30 '24 14:08 hakman

@sozercan This looks amazing. Should make maintaining this repo much easier. @wangzhen127 Could you please take a look? /lgtm

hakman avatar Aug 30 '24 14:08 hakman

Thanks for setting this up! There were several recent changes on .github/workflows/update-deps.yml. @jingxu97 Can you take a look to see if this satisfy your needs? Or if any followup change is needed?

wangzhen127 avatar Sep 13 '24 16:09 wangzhen127

Ping @wangzhen127 @jingxu97

hakman avatar Sep 17 '24 15:09 hakman

sorry for the delay, I think this is good for our use case.

jingxu97 avatar Sep 17 '24 17:09 jingxu97

/lgtm

wangzhen127 avatar Sep 18 '24 16:09 wangzhen127

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, sozercan, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 18 '24 16:09 k8s-ci-robot