node-problem-detector icon indicating copy to clipboard operation
node-problem-detector copied to clipboard

add threshold of pattern match on systemlogmonitor

Open smileusd opened this issue 2 years ago • 9 comments

This pr to add the feature on systemlogmonitor to trigger the condition only repeat match the rule pattern in a period.
For example I want add a pattern that only occur 3 times in 1 hour can trigger condition. This feature give a template for all systemlogmonitor to configure it.
If not configure them, that would be no change.

smileusd avatar May 25 '23 15:05 smileusd

Hi @smileusd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 25 '23 15:05 k8s-ci-robot

@Random-Liu PTAL

smileusd avatar May 25 '23 15:05 smileusd

/ok-to-test

I will take a look at this PR next week, I'm a bit swamped with other work this one.

mmiranda96 avatar May 25 '23 16:05 mmiranda96

@mmiranda96 Thank you trigger e2e. I will fix the test first.

smileusd avatar May 25 '23 17:05 smileusd

@mmiranda96 PTAL

smileusd avatar Jun 26 '23 07:06 smileusd

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smileusd Once this PR has been reviewed and has the lgtm label, please assign xueweiz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 29 '23 20:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 01 '24 08:03 k8s-triage-robot

@smileusd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-npd-e2e-node ea552685f2ed53fb50557555d4de06e5b4b5b0d3 link true /test pull-npd-e2e-node
pull-npd-e2e-test ea552685f2ed53fb50557555d4de06e5b4b5b0d3 link true /test pull-npd-e2e-test
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags ea552685f2ed53fb50557555d4de06e5b4b5b0d3 link true /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags
pull-npd-e2e-kubernetes-gce-gci ea552685f2ed53fb50557555d4de06e5b4b5b0d3 link true /test pull-npd-e2e-kubernetes-gce-gci
pull-npd-e2e-kubernetes-gce-gci-custom-flags ea552685f2ed53fb50557555d4de06e5b4b5b0d3 link true /test pull-npd-e2e-kubernetes-gce-gci-custom-flags
pull-npd-e2e-kubernetes-gce-ubuntu ea552685f2ed53fb50557555d4de06e5b4b5b0d3 link true /test pull-npd-e2e-kubernetes-gce-ubuntu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Mar 11 '24 15:03 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 10 '24 15:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar May 10 '24 15:05 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 10 '24 15:05 k8s-ci-robot