node-problem-detector
node-problem-detector copied to clipboard
kubernetes
:seedling: Remove Checking Docker Daemon
The Docker Daemon is no longer supported by Kubernetes. This PR removes corresponding code.
Hi @guettli. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: guettli Once this PR has been reviewed and has the lgtm label, please assign wangzhen127 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I think this is a good candidate to merge after cutting the branch. Any thoughts? /cc @SergeyKanzhelev @wangzhen127
I think this is a good candidate to merge after cutting the branch. Any thoughts? /cc @SergeyKanzhelev @wangzhen127
My only thought is that there is a https://github.com/Mirantis/cri-dockerd that will benefit from having this code.
Hi @yevchuk-kostiantyn @anaxdev @awmirantis @smerkviladze @mlimardo1984 (from https://github.com/Mirantis/cri-dockerd/blob/master/.github/CODEOWNERS), are you interested to help support these monitors?
@guettli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-npd-e2e-kubernetes-gce-ubuntu | dab43ba48a5ffdbfc26959dc7f1c3d40790ef19f | link | true | /test pull-npd-e2e-kubernetes-gce-ubuntu |
| pull-npd-e2e-kubernetes-gce-gci | dab43ba48a5ffdbfc26959dc7f1c3d40790ef19f | link | true | /test pull-npd-e2e-kubernetes-gce-gci |
| pull-npd-e2e-kubernetes-gce-gci-custom-flags | dab43ba48a5ffdbfc26959dc7f1c3d40790ef19f | link | true | /test pull-npd-e2e-kubernetes-gce-gci-custom-flags |
| pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags | dab43ba48a5ffdbfc26959dc7f1c3d40790ef19f | link | true | /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags |
| pull-npd-e2e-test | dab43ba48a5ffdbfc26959dc7f1c3d40790ef19f | link | true | /test pull-npd-e2e-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Hi @SergeyKanzhelev, thank you for tagging us and letting us know about this PR! It's true that customers of cri-dockerd (MCR/Docker) and node-problem-detector expect to have Docker Daemon monitors. We are definitely interested in maintaining and supporting them!
Please let us know the community's final decision. Meanwhile, we will familiarize ourselves with the contributing guidelines of this repository and define our workflow. Thanks again for letting us know!
Hi @SergeyKanzhelev, thank you for tagging us and letting us know about this PR! It's true that customers of cri-dockerd (MCR/Docker) and node-problem-detector expect to have Docker Daemon monitors. We are definitely interested in maintaining and supporting them!
Please let us know the community's final decision. Meanwhile, we will familiarize ourselves with the contributing guidelines of this repository and define our workflow. Thanks again for letting us know!
I do not see a problem keeping docker monitors around. Especially if you know any users using it or planning to use it. I think we should close this PR and instead concentrating on making monitors and configurations as modular as possible.
@yevchuk-kostiantyn I would be curious to see feedback from people using NPD on nodes with cri-dockerd. Also if you want to review what NPD monitors for docker - it may be useful.
Also as a side note, some customers are running Docker for building images or running containers "outside" of the k8s control. Those may benefit from Docker monitoring.
If there is no objections, let's close this PR. @guettli thank you for proposing it
@SergeyKanzhelev I think this PR has some valid changes. Let's discuss a little before closing.
I am fine with keeping the checks. But we should document the use-case. I guess only few people know that docker daemon still gets used.
Where would be a good place for documenting that?
I am fine with keeping the checks. But we should document the use-case. I guess only few people know that docker daemon still gets used.
Where would be a good place for documenting that?
Somewhere on the readme page.
For docker - there is a thin line. I believe we disabled it for GKE. But I can imaging somebody may want the frequent restart monitor for nodes where docker is used to run some CI environment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.