kubernetes
remote for the contributors fork is hardcoded in ISO build process
What Happened?
The primary issue is in the ISO build process where the Jenkins CI build script is trying to add a git remote for the contributor's fork, but it's failing because:
Repository naming mismatch: The build script assumes the contributor's fork is named minikube, but the actual fork is named minikube-fork SSH access issue: The build script is trying to use SSH to access [email protected]:vtri950/minikube.git which doesn't exist
observed in https://github.com/kubernetes/minikube/pull/21997
Attach the log file
https://storage.cloud.google.com/minikube-builds/logs/21997/0cbf9da/iso_build.txt
Operating System
None
Driver
None
More info on the problem:
The minikube build iso (and image) script is assuming that the user fork is named "minikube": https://github.com/kubernetes/minikube/blob/5df4e212347d565ae5f7666f592ea848e51063a0/hack/jenkins/build_iso.sh#L91
Here is a build log from #21997:
+ git remote add vtri950 [email protected]:vtri950/minikube.git
+ git fetch vtri950
ERROR: Repository not found.
fatal: Could not read from remote repository.
If the fork has a different name (e.g. https://github.com/vtri950/minikube-fork), the git command fails, trying to access non-existing fork, or the wrong fork.
