minikube
minikube copied to clipboard
kubernetes
kvm2 driver: Use scsi cdrom for arm64
On linux/aarch64 (e.g. Asahi Linux on MacBook M*) booting from SATA cdrom is broken and the VM drops into the UEFI shell.
It seems that linux/aarch64 supports only virtio and scsi devices[1]. Replace with scsi cdrom (like the x86 version) and addd a virtio-scsi controller since the default scsi controller does not boot as well.
[1] https://kubevirt.io/user-guide/virtual_machines/virtual_machines_on_Arm64/#disks-and-volumes
Fixes #18238
Hi @nirs. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Build and install
make
prog="out/docker-machine-driver-kvm2"
rm -f "$prog"*
make "$prog"
cp "$prog" ~/.minikube/bin/
Starting a cluster
$ out/minikube start --driver kvm2 -p dr1 --network default
😄 [dr1] minikube v1.32.0 on Fedora 39 (arm64)
✨ Using the kvm2 driver based on user configuration
💿 Downloading VM boot image ...
> minikube-v1.32.1-1708020063...: 65 B / 65 B [---------] 100.00% ? p/s 0s
> minikube-v1.32.1-1708020063...: 344.04 MiB / 344.04 MiB 100.00% 23.81 M
👍 Starting control plane node dr1 in cluster dr1
🔥 Creating kvm2 VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🐳 Preparing Kubernetes v1.28.4 on Docker 24.0.7 ...
▪ Generating certificates and keys ...
▪ Booting up control plane ...
▪ Configuring RBAC rules ...
🔗 Configuring bridge CNI (Container Networking Interface) ...
▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟 Enabled addons: storage-provisioner, default-storageclass
🔎 Verifying Kubernetes components...
🏄 Done! kubectl is now configured to use "dr1" cluster and "default" namespace by default
I recall there was a lot of hassle with the CD-rom drivers with the initial arm64 initiative, but if it works OK in qemu2 too...
The minikube ISO has been updated since, so it is possible that the new OS works better (like with a new kernel or such?)
kvm2 driver with docker runtime
+-------------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 18239) |
+-------------------+----------+---------------------+
| ⚠️ minikube start | 52.0s | 72.7s ⚠️ |
| enable ingress | 25.8s | 25.8s |
+-------------------+----------+---------------------+
Times for minikube start: 49.4s 52.2s 52.4s 51.3s 54.8s Times for minikube (PR 18239) start: 164.3s 49.4s 50.4s 48.5s 51.2s
Times for minikube ingress: 26.5s 27.1s 26.7s 26.0s 22.6s Times for minikube (PR 18239) ingress: 26.7s 26.6s 26.6s 25.6s 23.7s
docker driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 18239) |
+----------------+----------+---------------------+
| minikube start | 24.3s | 22.4s |
| enable ingress | 20.4s | 20.5s |
+----------------+----------+---------------------+
Times for minikube ingress: 21.3s 19.8s 20.3s 20.3s 20.4s Times for minikube (PR 18239) ingress: 21.3s 20.3s 20.3s 20.3s 20.3s
Times for minikube start: 26.1s 25.7s 22.1s 22.4s 25.3s Times for minikube (PR 18239) start: 22.4s 22.3s 21.9s 22.7s 22.8s
docker driver with containerd runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 18239) |
+----------------+----------+---------------------+
| minikube start | 21.8s | 21.9s |
| enable ingress | 31.0s | 34.1s |
+----------------+----------+---------------------+
Times for minikube (PR 18239) start: 21.4s 21.9s 21.9s 23.5s 21.0s Times for minikube start: 21.8s 21.3s 23.4s 21.0s 21.6s
Times for minikube ingress: 30.8s 30.8s 30.8s 31.8s 30.9s Times for minikube (PR 18239) ingress: 31.3s 46.8s 30.8s 30.8s 30.8s
These are the flake rates of all failed tests.
| Environment | Failed Tests | Flake Rate (%) |
|---|---|---|
| Docker_Linux_containerd_arm64 | TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) | 2.91 (chart) |
| Docker_macOS | TestMountStart/serial/VerifyMountPostStop (gopogh) | 5.32 (chart) |
| Docker_macOS | TestMissingContainerUpgrade (gopogh) | 7.29 (chart) |
| Hyperkit_macOS | TestDockerFlags (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/parallel/CpCmd (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/parallel/SSHCmd (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/KubeContext (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/KubectlGetPods (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/LogsCmd (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/LogsFileCmd (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/MinikubeKubectlCmd (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/SoftStart (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/serial/StartWithProxy (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestImageBuild/serial/Setup (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestJSONOutput/pause/Command (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestJSONOutput/start/Command (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestJSONOutput/start/parallel/DistinctCurrentSteps (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestJSONOutput/start/parallel/IncreasingCurrentSteps (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestJSONOutput/unpause/Command (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestMultiNode/serial/MultiNodeLabels (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestMultiNode/serial/ProfileList (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestPause/serial/Start (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestRunningBinaryUpgrade (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) | 17.59 (chart) |
| Hyperkit_macOS | TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) | 17.76 (chart) |
| Hyperkit_macOS | TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) | 17.76 (chart) |
| Hyperkit_macOS | TestMultiNode/serial/ValidateNameConflict (gopogh) | 17.92 (chart) |
| More tests... | Continued... |
Too many tests failed - See test logs for more details.
To see the flake rates of all tests by environment, click here.
Failing tests look similar to #18241 - change in libvirt domain xml cannot break other drivers.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: afbjorklund, BlaineEXE, medyagh, nirs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [afbjorklund,medyagh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment