minikube icon indicating copy to clipboard operation
minikube copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Add `local-path-provisioner` addon

Open presztak opened this issue 2 years ago • 5 comments

This PR adds local-path-provisioner as addon that supports multi-node setups. It resolves some issues which happend with standard storage-provisioner on multi-node cluster. Fixes: #12165 #12360

In addition also fixes issue with setting default storage class. Currently is not working properly because enableOrDisableStorageClasses tries to set storage class as default before it is enabled.

Example of usage:

  1. Enable addon:
$ minikube addons enable storage-provisioner-rancher
❗  storage-provisioner-rancher is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.
    ▪ Using image docker.io/rancher/local-path-provisioner:v0.0.22
    ▪ Using image docker.io/busybox:stable
🌟  The 'storage-provisioner-rancher' addon is enabled

$ kubectl get pods -n local-path-storage
NAME                                     READY   STATUS    RESTARTS   AGE
local-path-provisioner-7f58b4649-tnkj2   1/1     Running   0          34s

$ kubectl get sc
NAME                   PROVISIONER                RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
local-path (default)   rancher.io/local-path      Delete          WaitForFirstConsumer   false                  3m23s
standard               k8s.io/minikube-hostpath   Delete          Immediate              false                  3m59s
  1. Create pvc and pod with following yaml:
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
 name: test-pvc
spec:
 accessModes:
   - ReadWriteOnce
 resources:
   requests:
     storage: 64Mi
---
apiVersion: v1
kind: Pod
metadata:
 name: test-local-path
spec:
 nodeSelector:
   "kubernetes.io/hostname": "minikube-m02"
 containers:
 - name: busybox
   image: busybox:stable
   command: ["sh", "-c", "echo 'local-path-provisioner' > /test/file1"]
   volumeMounts:
   - name: data
     mountPath: /test
 volumes:
 - name: data
   persistentVolumeClaim:
     claimName: test-pvc

$ kubectl get pvc
NAME       STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
test-pvc   Bound    pvc-f07e253b-fea7-433a-b0ac-1bcea3f77076   64Mi       RWO            local-path     5m19s

$ kubectl get pods -o wide
NAME              READY   STATUS      RESTARTS   AGE     IP           NODE           NOMINATED NODE   READINESS GATES
test-local-path   0/1     Completed   0          5m19s   10.244.1.5   minikube-m02   <none>           <none>
  1. On the second node we are able to see created file with content local-path-provisioner:
$ minikube ssh -n minikube-m02 "cat /opt/local-path-provisioner/pvc-f07e253b-fea7-433a-b0ac-1bcea3f77076_default_test-pvc/file1"
local-path-provisioner

presztak avatar Oct 03 '22 19:10 presztak

Can one of the admins verify this patch?

minikube-bot avatar Oct 03 '22 19:10 minikube-bot

thank you very much @resztak for this PR, do you mind sharing output of example of using this addon ? maybe consider adding an entry to our website either https://minikube.sigs.k8s.io/docs/tutorials/ or

medyagh avatar Oct 03 '22 21:10 medyagh

@medyagh I've added example of usage and tutorial.

presztak avatar Oct 04 '22 20:10 presztak

@presztak thank you very much for this contribution this looks good to me, once @spowelljr approves it

medyagh avatar Oct 05 '22 18:10 medyagh

@spowelljr I've added integration test.

presztak avatar Jan 14 '23 13:01 presztak

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 09 '23 06:06 k8s-triage-robot

/ok-to-test

spowelljr avatar Jun 14 '23 03:06 spowelljr

kvm2 driver with docker runtime error collecting results for kvm2 driver: timing run 1 with minikube (PR 15062): timing cmd: [/home/jenkins/.minikube/minikube-binaries/15062/minikube start --driver=kvm2 --container-runtime=docker]: waiting for minikube: exit status 90 docker driver with docker runtime error downloading artifacts: artifact download start: exit status 81docker driver with containerd runtime error downloading artifacts: artifact download start: exit status 81

minikube-pr-bot avatar Jun 14 '23 05:06 minikube-pr-bot

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_crio_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_crio TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_docker_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
KVM_Linux_crio TestAddons/parallel/LocalPath (gopogh) n/a
KVM_Linux TestAddons/parallel/LocalPath (gopogh) n/a
none_Linux TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_docker_arm64 TestNoKubernetes/serial/StartNoArgs (gopogh) 0.00 (chart)
KVM_Linux TestPreload (gopogh) 3.29 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 8.76 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 8.76 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot avatar Jun 14 '23 08:06 minikube-pr-bot

Local path test is failing due to the test-local-path pod crashing with:

  Warning  BackOff    4s (x5 over 45s)  kubelet            Back-off restarting failed container busybox in pod test-local-path_default(0bb63a24-bb38-4834-b57f-4259596ac7e0)

spowelljr avatar Jun 14 '23 16:06 spowelljr

hi @presztak are you still interested in finishing this PR ?

medyagh avatar Sep 06 '23 18:09 medyagh

Hi @medyagh, yes. I'll finish soon.

presztak avatar Sep 06 '23 19:09 presztak

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 49.8s               |
| enable ingress | 27.8s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.2s 27.1s 27.6s 27.7s 28.6s Times for minikube (PR 15062) ingress: 28.7s 27.1s 27.1s 29.6s 26.7s

Times for minikube start: 52.7s 52.1s 46.5s 52.3s 51.2s Times for minikube (PR 15062) start: 50.1s 46.1s 49.7s 51.3s 51.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 24.3s    | 25.1s               |
| enable ingress | 21.1s    | 20.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.8s 20.9s 20.9s 21.8s 20.8s Times for minikube (PR 15062) ingress: 20.8s 20.8s 20.9s 20.3s 20.8s

Times for minikube start: 24.7s 24.2s 25.1s 22.2s 25.3s Times for minikube (PR 15062) start: 25.2s 24.4s 24.9s 25.1s 25.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.3s               |
| enable ingress | 34.8s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 23.9s 19.9s 20.7s 23.5s Times for minikube (PR 15062) start: 20.5s 23.8s 20.7s 20.4s 21.3s

Times for minikube ingress: 31.3s 31.4s 32.3s 47.3s 31.4s Times for minikube (PR 15062) ingress: 33.4s 32.3s 31.3s 31.3s 31.4s

minikube-pr-bot avatar Sep 11 '23 19:09 minikube-pr-bot

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_containerd TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_crio_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_crio TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_docker_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux TestAddons/parallel/LocalPath (gopogh) n/a
Hyperkit_macOS TestAddons/parallel/LocalPath (gopogh) n/a
Hyper-V_Windows TestAddons/parallel/LocalPath (gopogh) n/a
KVM_Linux_containerd TestAddons/parallel/LocalPath (gopogh) n/a
none_Linux TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_containerd TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyper-V_Windows TestMountStart/serial/RestartStopped (gopogh) 0.00 (chart)
Hyper-V_Windows TestOffline (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 1.67 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 1.67 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 1.67 (chart)
Hyper-V_Windows TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 1.67 (chart)
Hyperkit_macOS TestMinikubeProfile (gopogh) 15.57 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/RunSecondTunnel (gopogh) 43.64 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot avatar Sep 11 '23 21:09 minikube-pr-bot

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 50.6s    | 50.4s               |
| enable ingress | 28.4s    | 28.3s               |
+----------------+----------+---------------------+

Times for minikube start: 55.1s 48.9s 49.9s 50.0s 49.3s Times for minikube (PR 15062) start: 50.8s 50.3s 49.7s 51.9s 49.5s

Times for minikube ingress: 28.7s 28.2s 28.7s 27.2s 29.2s Times for minikube (PR 15062) ingress: 28.2s 28.7s 27.7s 28.2s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 24.2s               |
| enable ingress | 21.1s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 22.1s 24.9s 24.9s 24.9s Times for minikube (PR 15062) start: 24.3s 21.3s 24.7s 24.7s 25.9s

Times for minikube ingress: 20.8s 20.8s 20.8s 22.3s 20.8s Times for minikube (PR 15062) ingress: 20.8s 20.9s 20.9s 21.3s 20.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 21.3s    | 22.7s               |
| enable ingress | 33.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 20.3s 23.8s 20.9s 20.7s 20.7s Times for minikube (PR 15062) start: 23.1s 22.7s 20.8s 23.4s 23.5s

Times for minikube ingress: 32.3s 31.3s 26.4s 31.4s 47.3s Times for minikube (PR 15062) ingress: 31.3s 31.3s 31.3s 31.4s 32.3s

minikube-pr-bot avatar Sep 12 '23 23:09 minikube-pr-bot

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_crio_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux_docker_arm64 TestAddons/parallel/LocalPath (gopogh) n/a
none_Linux TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 0.00 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 4.43 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 4.43 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 4.43 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 4.43 (chart)
QEMU_macOS TestFunctional/parallel/Version/components (gopogh) 4.43 (chart)
QEMU_macOS TestFunctional/serial/LogsCmd (gopogh) 4.43 (chart)
Hyperkit_macOS TestNetworkPlugins/group/flannel/Start (gopogh) 4.94 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 5.06 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 5.06 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot avatar Sep 13 '23 00:09 minikube-pr-bot

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 50.5s               |
| enable ingress | 27.7s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube start: 54.6s 48.1s 48.4s 49.7s 50.6s Times for minikube (PR 15062) start: 52.6s 52.1s 49.7s 50.0s 48.3s

Times for minikube (PR 15062) ingress: 29.2s 29.2s 28.1s 28.2s 28.6s Times for minikube ingress: 26.6s 28.1s 28.6s 27.2s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 22.9s               |
| enable ingress | 21.4s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.9s 22.3s 24.7s 21.6s 21.9s Times for minikube (PR 15062) start: 23.8s 24.1s 21.1s 23.6s 21.8s

Times for minikube ingress: 20.8s 22.8s 20.8s 20.8s 21.8s Times for minikube (PR 15062) ingress: 20.8s 20.8s 20.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.8s               |
| enable ingress | 37.7s    | 30.9s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 22.7s 19.9s 23.8s 20.3s Times for minikube (PR 15062) start: 21.2s 23.6s 20.3s 21.5s 22.4s

Times for minikube ingress: 31.3s 47.3s 31.3s 47.3s 31.3s Times for minikube (PR 15062) ingress: 30.3s 30.3s 31.3s 31.3s 31.3s

minikube-pr-bot avatar Sep 13 '23 22:09 minikube-pr-bot

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 1.74 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 1.74 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 1.74 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 1.74 (chart)
Hyperkit_macOS TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh) 1.74 (chart)
Hyperkit_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 4.07 (chart)
Hyperkit_macOS TestMinikubeProfile (gopogh) 15.12 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot avatar Sep 13 '23 23:09 minikube-pr-bot

@spowelljr @medyagh can you take another look on this?

presztak avatar Sep 14 '23 20:09 presztak

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 50.9s               |
| enable ingress | 27.6s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 53.2s 49.0s 49.0s 51.0s 52.8s Times for minikube (PR 15062) start: 50.5s 51.2s 48.9s 51.9s 51.8s

Times for minikube ingress: 28.6s 27.7s 28.1s 27.7s 25.7s Times for minikube (PR 15062) ingress: 27.6s 29.2s 27.6s 27.8s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 22.5s               |
| enable ingress | 21.3s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 21.4s 25.5s 21.6s 24.6s Times for minikube (PR 15062) start: 22.6s 21.5s 21.9s 22.0s 24.1s

Times for minikube ingress: 22.8s 20.8s 20.8s 21.3s 20.8s Times for minikube (PR 15062) ingress: 20.8s 20.8s 20.8s 20.8s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 21.9s               |
| enable ingress | 37.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 20.9s 21.3s 23.3s 24.0s Times for minikube (PR 15062) start: 20.3s 23.1s 20.3s 22.6s 23.2s

Times for minikube ingress: 31.3s 47.3s 47.3s 31.3s 31.3s Times for minikube (PR 15062) ingress: 31.3s 31.3s 31.3s 32.3s 31.3s

minikube-pr-bot avatar Sep 14 '23 20:09 minikube-pr-bot

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestPause/serial/PauseAgain (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 1.32 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh) 1.32 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 1.32 (chart)
KVM_Linux TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 3.43 (chart)
KVM_Linux TestStartStop/group/embed-certs/serial/Pause (gopogh) 3.43 (chart)
KVM_Linux TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 3.43 (chart)
KVM_Linux TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 3.43 (chart)
KVM_Linux TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 3.43 (chart)
KVM_Linux TestNoKubernetes/serial/StartNoArgs (gopogh) 4.14 (chart)
Hyperkit_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.02 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot avatar Sep 14 '23 22:09 minikube-pr-bot

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 50.0s    | 50.2s               |
| enable ingress | 28.1s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.2s 27.8s 28.3s 28.1s 28.1s Times for minikube (PR 15062) ingress: 28.7s 26.1s 27.6s 28.2s 28.1s

Times for minikube start: 50.8s 50.0s 49.9s 50.0s 49.6s Times for minikube (PR 15062) start: 52.5s 49.5s 49.4s 50.5s 49.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 23.8s               |
| enable ingress | 21.0s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 25.0s 22.0s 24.6s 21.3s 24.3s Times for minikube (PR 15062) start: 21.7s 24.3s 25.7s 25.0s 22.4s

Times for minikube ingress: 20.8s 20.8s 20.8s 20.8s 21.8s Times for minikube (PR 15062) ingress: 20.8s 21.8s 20.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.0s               |
| enable ingress | 31.7s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 20.0s 23.7s 22.8s 23.3s 22.6s Times for minikube (PR 15062) start: 20.0s 23.2s 23.8s 20.4s 22.7s

Times for minikube ingress: 32.3s 31.3s 32.3s 31.3s 31.3s Times for minikube (PR 15062) ingress: 31.3s 31.3s 31.3s 31.3s 31.3s

minikube-pr-bot avatar Sep 23 '23 16:09 minikube-pr-bot

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 52.2s    | 51.0s               |
| enable ingress | 27.2s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube start: 56.0s 52.2s 51.1s 50.8s 50.7s Times for minikube (PR 15062) start: 51.3s 50.5s 52.6s 50.2s 50.4s

Times for minikube ingress: 25.2s 28.6s 28.2s 26.1s 28.1s Times for minikube (PR 15062) ingress: 29.7s 28.7s 30.2s 28.6s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 24.7s               |
| enable ingress | 21.5s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 24.2s 24.3s 22.4s 24.7s Times for minikube (PR 15062) start: 24.8s 24.4s 24.1s 25.5s 24.8s

Times for minikube ingress: 21.3s 22.8s 20.8s 21.8s 20.8s Times for minikube (PR 15062) ingress: 20.8s 20.8s 20.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15062) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 22.4s               |
| enable ingress | 31.1s    | 30.9s               |
+----------------+----------+---------------------+

Times for minikube start: 19.9s 19.8s 23.9s 21.7s 23.0s Times for minikube (PR 15062) start: 21.3s 24.2s 23.8s 20.6s 22.1s

Times for minikube ingress: 31.3s 30.3s 31.3s 31.3s 31.3s Times for minikube (PR 15062) ingress: 30.3s 31.3s 31.3s 30.3s 31.3s

minikube-pr-bot avatar Sep 23 '23 16:09 minikube-pr-bot

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
QEMU_macOS TestAddons/parallel/LocalPath (gopogh) n/a
Docker_Linux TestAddons/parallel/Registry (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.16.0/preload-exists (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/InspektorGadget (gopogh) 0.57 (chart)
KVM_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 1.72 (chart)
Hyperkit_macOS TestCertExpiration (gopogh) 4.73 (chart)
Docker_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 7.51 (chart)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 18.97 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 19.54 (chart)
Hyperkit_macOS TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 20.12 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot avatar Sep 23 '23 17:09 minikube-pr-bot

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 4.94 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 4.94 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 4.94 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 4.94 (chart)
QEMU_macOS TestFunctional/parallel/Version/components (gopogh) 4.94 (chart)
QEMU_macOS TestFunctional/serial/LogsCmd (gopogh) 4.94 (chart)
QEMU_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 4.94 (chart)
QEMU_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 4.94 (chart)
Hyper-V_Windows TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 5.17 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 5.56 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/SSHCmd (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 6.17 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh) 6.17 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot avatar Sep 23 '23 19:09 minikube-pr-bot

Hi all, I was wondering if there's a way to enable this in my minikube install while it gets merged or should I try the workaround from https://github.com/kubernetes/minikube/issues/12165#issuecomment-1052642443

Thanks all for your help and contributions!

andresmmujica avatar Sep 24 '23 22:09 andresmmujica

Hi all, I was wondering if there's a way to enable this in my minikube install while it gets merged or should I try the workaround from #12165 (comment)

Thanks all for your help and contributions!

You can checkout this branch and build it from source with make if you have Go installed

spowelljr avatar Sep 25 '23 17:09 spowelljr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, presztak, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 26 '23 21:09 k8s-ci-robot