kubernetes icon indicating copy to clipboard operation
kubernetes copied to clipboard

Promote KubeletTracing featuregate to GA

Open dashpole opened this issue 10 months ago • 15 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promote the KubeletTracing featuregate to GA.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promoted the `KubeletTracing` feature gate to GA. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Please use the following format for linking documentation:

  • KEP: https://github.com/kubernetes/enhancements/issues/2831

cc @kubernetes/sig-instrumentation-leads @haircommander

dashpole avatar Jun 16 '25 20:06 dashpole

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Jun 16 '25 20:06 k8s-ci-robot

/sig node /sig instrumentation /priority important-soon

dashpole avatar Jun 16 '25 20:06 dashpole

/test pull-kubernetes-e2e-gce

dashpole avatar Jun 17 '25 15:06 dashpole

/lgtm /approve

wojtek-t avatar Jun 18 '25 06:06 wojtek-t

LGTM label has been added.

Git tree hash: 6ec5c3ca2acb990975a29c80f7b00251e888c1d2

k8s-ci-robot avatar Jun 18 '25 06:06 k8s-ci-robot

/approve

dims avatar Jun 18 '25 10:06 dims

@SergeyKanzhelev done in https://github.com/kubernetes/kubernetes/pull/132341/commits/eb781f6eff57a45da96d214651b07e1ea4b1fd41

dashpole avatar Jun 18 '25 17:06 dashpole

LGTM label has been added.

Git tree hash: ff56b7a3332d66e6e886d3ab71eb5f94eb70794f

k8s-ci-robot avatar Jun 18 '25 18:06 k8s-ci-robot

/assign @deads2k

as per bot recommendation

SergeyKanzhelev avatar Jun 18 '25 18:06 SergeyKanzhelev

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

k8s-triage-robot avatar Jun 18 '25 18:06 k8s-triage-robot

/test pull-kubernetes-node-e2e-containerd /test pull-kubernetes-unit-windows-master /test pull-kubernetes-unit

dashpole avatar Jun 18 '25 18:06 dashpole

/test pull-kubernetes-unit-windows-master

dashpole avatar Jun 19 '25 19:06 dashpole

Failure is unrelated: https://github.com/kubernetes/kubernetes/issues/132424

dashpole avatar Jun 23 '25 17:06 dashpole

/triage accept

richabanker avatar Jun 26 '25 16:06 richabanker

@richabanker: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

In response to this:

/triage accept

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 26 '25 16:06 k8s-ci-robot

/triage accepted

richabanker avatar Jun 26 '25 16:06 richabanker

/test pull-kubernetes-unit

dashpole avatar Jun 30 '25 12:06 dashpole

/lgtm /approve /assign @liggitt @deads2k

pacoxu avatar Jul 07 '25 09:07 pacoxu

LGTM label has been added.

Git tree hash: c62be3a5e042aba9b9d52b21ed4ac073e673de2a

k8s-ci-robot avatar Jul 07 '25 09:07 k8s-ci-robot

@liggitt @saschagrunert there are some no_parent_owners that keeps this PR from merging, can you please approve?

dims avatar Jul 12 '25 11:07 dims

/approve /lgtm

cpanato avatar Jul 12 '25 11:07 cpanato

/approve

liggitt avatar Jul 14 '25 20:07 liggitt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dashpole, dims, liggitt, pacoxu, SergeyKanzhelev, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 14 '25 20:07 k8s-ci-robot