kubernetes icon indicating copy to clipboard operation
kubernetes copied to clipboard

suppress git worktree status output to reduce log noise in govulncheck

Open gal-dahan opened this issue 7 months ago • 9 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR silences the output of the git worktree add command in hack/verify-govulncheck.sh by redirecting it to /dev/null.

Suppressing this output helps reduce log noise during verification runs.

Which issue(s) this PR is related to:

Fixes #132153

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

NONE

gal-dahan avatar Jun 07 '25 17:06 gal-dahan

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 07 '25 17:06 k8s-ci-robot

Hi @gal-dahan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 07 '25 17:06 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gal-dahan Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 07 '25 17:06 k8s-ci-robot

Hi, this is my first PR. Would appreciate a review and an /ok-to-test to run the CI 🙏 @BenTheElder @mikedanese

gal-dahan avatar Jun 07 '25 17:06 gal-dahan

/ok-to-test

BenTheElder avatar Jun 11 '25 02:06 BenTheElder

/ok-to-test

Thank you for the review! 🙏

Could you please add the following labels so the PR can move forward?

  • /lgtm
  • /approve

I've also added /release-note-none and /sig cli to address the missing label issues.

Really appreciate your help!

gal-dahan avatar Jun 15 '25 11:06 gal-dahan

/release-note-none

gal-dahan avatar Jun 15 '25 11:06 gal-dahan

I asked some of the reviewers in the issue #132153 which PR we should focus on.

PatrickLaabs avatar Jun 18 '25 07:06 PatrickLaabs

@gal-dahan Thank you for the lovely PR, and sorry for the conflict resulting from the high interest in creating this fix.

/close because we followed up on https://github.com/kubernetes/kubernetes/pull/132155 sooner

tabbysable avatar Jul 09 '25 00:07 tabbysable

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 09 '25 00:07 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Oct 05 '25 15:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 05 '25 15:10 k8s-ci-robot