kubernetes icon indicating copy to clipboard operation
kubernetes copied to clipboard

Handle consistent LIST in watch cache to avoid incorrect semantics while setting ResourceVersion on options

Open serathius opened this issue 6 months ago • 7 comments

/kind cleanup

Cleanup after discovery of https://github.com/kubernetes/kubernetes/issues/132132 and fix https://github.com/kubernetes/kubernetes/pull/132244

This PR should make the code easier to understand.

Due to Snapshots from cache feature the watch cache started classifying consistent read with limit as legacy exact read. This is because the delegator incorrectly assumed that it can transform consistent read to notOlderThan request.

NONE

serathius avatar Jun 06 '25 15:06 serathius

/assign @wojtek-t

serathius avatar Jun 06 '25 15:06 serathius

/test pull-kubernetes-conformance-kind-ga-only-parallel

dims avatar Jun 06 '25 18:06 dims

@serathius i was playing with some test cases in case you find them useful - https://paste.openstack.org/show/bzSa1WUIAn2VlRyEAo4g/

I did not understand one scenario what would/should happen (see "too high RV, exact match" - line 220->227), the test hangs if i uncomment those lines.

dims avatar Jun 06 '25 18:06 dims

/retest

serathius avatar Jun 07 '25 07:06 serathius

/triage accepted /priority critical-urgent

serathius avatar Jun 09 '25 08:06 serathius

PTAL @wojtek-t

serathius avatar Jun 18 '25 07:06 serathius

/lgtm /approve

wojtek-t avatar Jun 26 '25 09:06 wojtek-t

LGTM label has been added.

Git tree hash: 84e45cf6a6801d7ccc020782044305cc576d703c

k8s-ci-robot avatar Jun 26 '25 09:06 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 26 '25 09:06 k8s-ci-robot