kubernetes
kubernetes copied to clipboard
Handle consistent LIST in watch cache to avoid incorrect semantics while setting ResourceVersion on options
/kind cleanup
Cleanup after discovery of https://github.com/kubernetes/kubernetes/issues/132132 and fix https://github.com/kubernetes/kubernetes/pull/132244
This PR should make the code easier to understand.
Due to Snapshots from cache feature the watch cache started classifying consistent read with limit as legacy exact read. This is because the delegator incorrectly assumed that it can transform consistent read to notOlderThan request.
NONE
/assign @wojtek-t
/test pull-kubernetes-conformance-kind-ga-only-parallel
@serathius i was playing with some test cases in case you find them useful - https://paste.openstack.org/show/bzSa1WUIAn2VlRyEAo4g/
I did not understand one scenario what would/should happen (see "too high RV, exact match" - line 220->227), the test hangs if i uncomment those lines.
/retest
/triage accepted /priority critical-urgent
PTAL @wojtek-t
/lgtm /approve
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: serathius, wojtek-t
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~staging/src/k8s.io/apiserver/pkg/storage/OWNERS~~ [wojtek-t]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment