kubernetes
[FG:InPlacePodVerticalScaling] Show CPU request in status only when configured
What type of PR is this?
/kind bug
What this PR does / why we need it:
The minimum CPU request is set to a container internally if a CPU request is not configured. This minimum request does not need displaying to users. This PR sets a CPU request to a pod status only when a CPU request is configured in the pod spec.
This PR also prevents the internal minimum CPU request from triggering an unexpected resize in computePodResizeAction().
Which issue(s) this PR fixes:
Fixes #126195
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Fixed a bug that the internal minimum CPU request is displayed in a pod status when only a memory request is configured in the pod and the `InPlacePodVerticalScaling` feature is enabled.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @hshiina. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hshiina Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2 /test pull-kubernetes-node-kubelet-serial-podresize
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I think this PR is superseded by https://github.com/kubernetes/kubernetes/pull/128680
Please take a look at the linked PR.
/close
@tallclair: Closed this PR.
In response to this:
I think this PR is superseded by https://github.com/kubernetes/kubernetes/pull/128680
Please take a look at the linked PR.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.