kubernetes
Remove deprecated sets.String from pkg/kubelet
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This removes deprecated sets.String from pkg/kubelet to avoid warning messages.
- s/sets.String/sets.New[string]/g
- s/sets.NewString/sets.New[string]/g
- Use sets.List instead of (sets.String).List
- ~Remove sets.String from util.GetPodVolumeNames as it's used in pkg/kubelet~ <- addressed by https://github.com/kubernetes/kubernetes/pull/124740
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
none
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
LGTM label has been added.
LGTM label has been added.
/assign @liggitt
Could you take a look? The PR just replaces deprecated sets.string, but needs api approval.
/assign @liggitt
Could you take a look? The PR just replaces deprecated sets.string, but needs api approval.
For pkg/kubelet/apis/config/OWNERS, only test is updated here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gjkim42, liggitt, mrunalp
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/kubelet/OWNERS~~ [liggitt,mrunalp]
- ~~pkg/kubelet/apis/config/OWNERS~~ [liggitt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@gjkim42: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kubernetes-integration | a10cd79f633cafdf9114a73f5cf3298fb24fa07d | link | unknown | /test pull-kubernetes-integration |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.