kubernetes icon indicating copy to clipboard operation
kubernetes copied to clipboard

Remove ioutil from client-go

Open inosato opened this issue 3 years ago • 6 comments

Signed-off-by: inosato [email protected]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove ioutil from client-go.

Which issue(s) this PR fixes:

Fixes # NONE Related to https://github.com/kubernetes/kubernetes/issues/100367

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


inosato avatar Jul 30 '22 11:07 inosato

Hi @inosato. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 30 '22 11:07 k8s-ci-robot

/assign @yliaog /triage accepted

fedebongio avatar Aug 02 '22 20:08 fedebongio

/ok-to-test

yliaog avatar Aug 10 '22 01:08 yliaog

/lgtm /approve

yliaog avatar Aug 10 '22 18:08 yliaog

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inosato, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 10 '22 18:08 k8s-ci-robot

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

k8s-triage-robot avatar Aug 10 '22 21:08 k8s-triage-robot