kubernetes icon indicating copy to clipboard operation
kubernetes copied to clipboard

chore(e2e): add e2e test for non graceful node shutdown

Open sonasingh46 opened this issue 2 years ago • 14 comments

Signed-off-by: Ashutosh Kumar [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds e2e test for non graceful shutdown of the node.

Ref: Blog Link: https://kubernetes.io/blog/2022/05/20/kubernetes-1-24-non-graceful-node-shutdown-alpha/ Feature PR Link: https://github.com/kubernetes/kubernetes/pull/108486 Issue Link : https://github.com/kubernetes/enhancements/issues/2268

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2268-non-graceful-shutdown

sonasingh46 avatar Jul 25 '22 06:07 sonasingh46

@sonasingh46: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 25 '22 06:07 k8s-ci-robot

Hi @sonasingh46. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 25 '22 06:07 k8s-ci-robot

/ok-to-test

palnabarun avatar Jul 25 '22 12:07 palnabarun

/assign

endocrimes avatar Jul 25 '22 13:07 endocrimes

/assign

xing-yang avatar Jul 25 '22 13:07 xing-yang

/assign @jingxu97 @gnufied

xing-yang avatar Jul 25 '22 13:07 xing-yang

/assign

dzjiang91 avatar Jul 25 '22 17:07 dzjiang91

/retest /lgtm

gnufied avatar Aug 10 '22 13:08 gnufied

Can you squash the commits?

gnufied avatar Aug 10 '22 14:08 gnufied

Can you squash the commits?

Done

sonasingh46 avatar Aug 10 '22 16:08 sonasingh46

/retest

gnufied avatar Aug 10 '22 17:08 gnufied

/lgtm /approve

gnufied avatar Aug 11 '22 02:08 gnufied

/assign @pohly

gnufied avatar Aug 11 '22 12:08 gnufied

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, sonasingh46

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 16 '22 16:08 k8s-ci-robot

/retest

sonasingh46 avatar Aug 18 '22 07:08 sonasingh46

/lgtm

gnufied avatar Aug 18 '22 17:08 gnufied