kubernetes
kubernetes copied to clipboard
kubernetes
WIP: Testing
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update volume snapshot controller and sidecar images to v6.0.1.
Which issue(s) this PR fixes:
Fixes # https://github.com/kubernetes-csi/external-snapshotter/issues/736
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
@xing-yang: This issue is currently awaiting triage.
If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xing-yang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cluster/addons/volumesnapshots/OWNERS~~ [xing-yang]
- ~~test/e2e/testing-manifests/storage-csi/OWNERS~~ [xing-yang]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @humblec, this PR is based on https://github.com/kubernetes/kubernetes/pull/110826 except that I removed the timeouts. It passed the snapshot tests now. Can you take a look?
Hi @humblec, this PR is based on #110826 except that I removed the timeouts. It passed the snapshot tests now. Can you take a look?
Sure @xing-yang .. one more difference from the referenced PR is the version of the provisioner which is 3.2.1 here instead of 3.2.0 . I have updated my PR to 3.2.1 and checking the tests pass on that.
Its interesting that , even after keeping only sidecar version changes, my PR tests fail. now the only difference between this PR and mine is that, this PR has not updated csi-snapshotter version https://github.com/kubernetes/kubernetes/pull/111373/files#diff-1e966d5d795fba59a8ceea256e18d4390e98c4b6fc5adeb135397ab391598174L24 and https://github.com/kubernetes/kubernetes/pull/110826/files#diff-d206a6719a9e122d9b370a436ccb2f1e80b7c257737f104b5f88fc8f7f3830a8L355 . I am wondering if you update these 2 lines for latest version , the tests pass or not @xing-yang
@xing-yang so this commit https://github.com/kubernetes/kubernetes/pull/111373/commits/d3b5760424c9d2622b3179ae40689b62f7eed694 make the test to fail as suspected :(
@xing-yang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kubernetes-e2e-gce-alpha-features | d3b5760424c9d2622b3179ae40689b62f7eed694 | link | false | /test pull-kubernetes-e2e-gce-alpha-features |
| pull-kubernetes-e2e-gce-storage-snapshot | d3b5760424c9d2622b3179ae40689b62f7eed694 | link | false | /test pull-kubernetes-e2e-gce-storage-snapshot |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@sonasingh46 pull-kubernetes-e2e-gce-storage-snapshot failed due a different reason (has to do with a snapshot image update that is tracked by a different issue). Please ignore this test.
The non-graceful node shutdown test is run as part of pull-kubernetes-e2e-gce-alpha-features. You only need to check this one. If it is confusing, please feel free to submit a different testing PR yourself.
Opened a new PR to verify/fix the failure https://github.com/kubernetes/kubernetes/pull/112790