kubectl icon indicating copy to clipboard operation
kubectl copied to clipboard
verified publisher icon kubernetes

Follow up on splitting Flags from Option on annotate command

Open iamNoah1 opened this issue 3 years ago • 7 comments

Following up on https://github.com/kubernetes/kubectl/issues/1276, we need some more refinement based on the review from @ardaguclu on https://github.com/kubernetes/kubernetes/pull/112817. Basically:

  • Move DryRunStrategy and DryRunVerifier from flags to options
  • Write Unit tests for https://github.com/kubernetes/kubernetes/pull/112817/files#diff-9ccf80373137694902ef1403ddc2640d3511785056ff8ee07292611b95bdcdffR268-R286
  • Write some integration tests in here: https://github.com/kubernetes/kubernetes/tree/534f052a8dfdd7b5861ee60d764d12da199c3bba/test/cmd

iamNoah1 avatar Nov 29 '22 18:11 iamNoah1

/kind cleanup

iamNoah1 avatar Nov 29 '22 18:11 iamNoah1

/remove-kind feature

iamNoah1 avatar Nov 29 '22 18:11 iamNoah1

/triage accepted /priority backlog

ardaguclu avatar Nov 30 '22 12:11 ardaguclu

/assign

iamNoah1 avatar Dec 18 '22 19:12 iamNoah1

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Jan 19 '24 22:01 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 18 '24 22:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 18 '24 22:05 k8s-triage-robot