kube-state-metrics
kube-state-metrics copied to clipboard
kubernetes
fix(customresourcestate): generate unique HELP message for each family
What this PR does / why we need it:
The family generator creates a family per GVK, this requires that the configuration has a unique HELP text per custom metric. This is not feasible when using wildcards as the generate will reuse the same HELP text for each GVK it finds.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
It does not change cardinality but does change the HELP text on metrics generated by CustomResourceState.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2384, fixes #2453
This issue is currently awaiting triage.
If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CatherineF-dev, Duologic
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CatherineF-dev]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
change looks pretty straight forward.
@Duologic can you push again to trigger CI? for some reason it didn't run.
@rexagod any thoughts?
@CatherineF-dev @rexagod @mrueg The review cycle for this PR has been very long, can I do something to speed that up?