kube-state-metrics icon indicating copy to clipboard operation
kube-state-metrics copied to clipboard

feat: Add timezone to kube_cronjob_info / Make kube_cronjob_next_schedule_time timezone-aware

Open mrueg opened this issue 1 year ago • 4 comments

What this PR does / why we need it: Cronjob is not timezone aware. How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) Adds one label to the kube_cronjob_info metric.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes/kube-state-metrics/issues/2206

mrueg avatar Apr 22 '24 08:04 mrueg

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 22 '24 08:04 k8s-ci-robot

/triage accepted /assign @dgrisonnet

logicalhan avatar May 02 '24 16:05 logicalhan

@dgrisonnet @rexagod anything left to do to get this change in?

mrueg avatar Jul 15 '24 16:07 mrueg

@dgrisonnet @rexagod Sorry for the ping, but this feature is pretty important to us since we can't set the timezone on AWS' Bottlerocket OS. Is there any way to accelerate the review process?

der-eismann avatar Sep 16 '24 12:09 der-eismann