kube-state-metrics
kube-state-metrics copied to clipboard
feat: Add timezone to kube_cronjob_info / Make kube_cronjob_next_schedule_time timezone-aware
What this PR does / why we need it: Cronjob is not timezone aware. How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) Adds one label to the kube_cronjob_info metric.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/kubernetes/kube-state-metrics/issues/2206
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mrueg
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mrueg]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/triage accepted /assign @dgrisonnet
@dgrisonnet @rexagod anything left to do to get this change in?
@dgrisonnet @rexagod Sorry for the ping, but this feature is pretty important to us since we can't set the timezone on AWS' Bottlerocket OS. Is there any way to accelerate the review process?