kube-state-metrics icon indicating copy to clipboard operation
kube-state-metrics copied to clipboard

Clean up `select {}`

Open CatherineF-dev opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) N/A

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

CatherineF-dev avatar Feb 13 '24 19:02 CatherineF-dev

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CatherineF-dev Once this PR has been reviewed and has the lgtm label, please assign mrueg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 13 '24 19:02 k8s-ci-robot

cc @mrueg to review.

Does this select {} have some special purposes?

CatherineF-dev avatar Feb 13 '24 19:02 CatherineF-dev

/assign @rexagod /triage accepted

dashpole avatar Feb 22 '24 17:02 dashpole

AFAIK the select here is used to block similar to an infinite for loop.

mrueg avatar Feb 23 '24 16:02 mrueg

Yep, closing.

rexagod avatar Feb 25 '24 19:02 rexagod