kube-state-metrics
kube-state-metrics copied to clipboard
kubernetes
Presubmit checks for stable metrics
What would you like to be added: A presubmit to validate stable metrics don't change metric name, add labels or delete labels.
Similar to k8s stable metrics presubmit.
Why is this needed: Guarantee stable metrics are stable.
Due to lack of presubmit check, some stable metrics are changed. For example,
- stable metric
kube_persistentvolume_infois changed in https://github.com/kubernetes/kube-state-metrics/pull/1814 - stable metric
kube_service_status_load_balancer_ingressis changed in https://github.com/kubernetes/kube-state-metrics/pull/1687
Describe the solution you'd like
- Import k8s metrics stability framework https://github.com/kubernetes/kube-state-metrics/pull/1844 and https://github.com/kubernetes/kube-state-metrics/pull/1976
- Presubmit check https://github.com/kubernetes/kube-state-metrics/pull/1836
Additional context
@CatherineF-dev: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@CatherineF-dev: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue has not been updated in over 1 year, and should be re-triaged.
You can:
- Confirm that this issue is still relevant with
/triage accepted(org members only) - Close this issue with
/close
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/
/remove-triage accepted
