kubernetes
feat: Add support for azuredisk-csi-driver
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: ThomasCardin / name: Thomas Cardin (2104e71d1da35dce5ad7e7f6c22745515432c245, 38253e21cada92ca00be6e1357a561b46da03e2b, 473517a1b9778e799ca647770c1bc8f6568b7b74, 61048e591eba08f2d196a809af69f9ba7189b051, 76d76291c18f6f5ee26a88b6dec29bdd2f9823fa, 921823439b86e514016091a7044e82390b090269, a281207dde5d9facbbc6bc0365f5bb76f27354cc, a789478747bf98ca9217b942f8e8caf48e6d813b, bf6fcef4d21ebc4bea9c667529812cb879dd7057, ca24d06c971306b33e10ce15b4fbd4e350185e78, eed90f14419113edc213e52d0386eafb21d72fde)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @ThomasCardin!
It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/kops has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @ThomasCardin. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I see here that there are several image versions (v1.33.5, v1.32.11, v1.31.12). Should I manage these versions like aws-ebs-csi-driver.addons.k8s.io does?
I see here that there are several image versions (v1.33.5, v1.32.11, v1.31.12). Should I manage these versions like aws-ebs-csi-driver.addons.k8s.io does?
Not in this stage. Just use the latest one.
@ThomasCardin the goal is to get this to pass, you can ignore the other failing tests for now: /test pull-kops-e2e-kubernetes-azure
@ThomasCardin sorry for not getting back to you sooner, no excuses here. I did test about a month ago and found out that the CSI driver actually fails to create the PV or crashes. Could not figure out why. For some reason, the controller cannot get a token to access the Azure API.