kubernetes
test: Use ephemeral discovery store for AWS
This PR is a follow up on https://github.com/kubernetes/k8s.io/issues/5127 to use an ephemeral discovery store/S3 bucket instead of a static one (s3://k8s-kops-ci-prow).
Related to https://github.com/kubernetes/k8s.io/issues/5127
cc @ameukam
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@xmudrii @ameukam tests are temporarily broken, so you may have to wait a few days with this.
@xmudrii @ameukam tests are temporarily broken, so you may have to wait a few days with this.
@hakman The current state of CI don't prevent us to validate some aspects of the PR: :-P
I0728 12:16:03.905852 16831 s3.go:127] Bucket k8s-infra-kops-state-4d6a-20250728120558 created successfully
I0728 12:16:04.427119 16831 s3.go:127] Bucket k8s-infra-kops-discovery-4d6a-20250728121603 created successfully
Deleted cluster: "presubmit.test-cncf-aws.k8s.io"
I0728 12:19:33.040823 16831 s3.go:173] Bucket k8s-infra-kops-state-4d6a-20250728120558 deleted
I0728 12:19:33.294451 16831 s3.go:173] Bucket k8s-infra-kops-discovery-4d6a-20250728121603 deleted
@hakman @rifelpet Please let us know once the tests are fixed. As @ameukam pointed out, this already looks promising, I'll do some more tests once they are working
@xmudrii Mind rebase your PR to include https://github.com/kubernetes/kops/pull/17523 ?
@xmudrii: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| presubmit-kops-aws-boskos | 76657d3a7c8eae8ed303747eb98c326146d68eb2 | link | true | /test presubmit-kops-aws-boskos |
| pull-kops-e2e-k8s-aws-amazonvpc | 826b8a1e50a809332d5b2ea1a17b42657d5a29c6 | link | true | /test pull-kops-e2e-k8s-aws-amazonvpc |
| pull-kops-e2e-k8s-aws-calico | 826b8a1e50a809332d5b2ea1a17b42657d5a29c6 | link | true | /test pull-kops-e2e-k8s-aws-calico |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
From https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-control-block-public-access.html
By default, new buckets, access points, and objects don't allow public access.
We should define the block policy with PutPublicAccessBlock
@hakman @xmudrii WDYT ?
From https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-control-block-public-access.html
By default, new buckets, access points, and objects don't allow public access.
We should define the block policy with PutPublicAccessBlock
@hakman @xmudrii WDYT ?
I think we should have a working, stable environment and take it from there. I still don't understand why we need this.
Merged via https://github.com/kubernetes/kops/pull/17809. Thank you @ameukam & @xmudrii ! /close
@hakman: Closed this PR.
In response to this:
Merged via https://github.com/kubernetes/kops/pull/17809. Thank you @ameukam & @xmudrii ! /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.