kops icon indicating copy to clipboard operation
kops copied to clipboard
verified publisher icon kubernetes

feat: for version command add fields

Open huhouhua opened this issue 5 months ago • 18 comments

Ref: https://github.com/kubernetes/kops/issues/17467

huhouhua avatar Jul 08 '25 20:07 huhouhua

Hi @huhouhua. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 08 '25 20:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 08 '25 20:07 k8s-ci-robot

@hakman can you review my pull request 🙇

huhouhua avatar Jul 08 '25 20:07 huhouhua

/ok-to-test

ameukam avatar Jul 09 '25 07:07 ameukam

/retest-required

huhouhua avatar Jul 09 '25 07:07 huhouhua

/retest

huhouhua avatar Jul 09 '25 08:07 huhouhua

@ameukam @hakman review the workflows

huhouhua avatar Jul 09 '25 09:07 huhouhua

@huhouhua I think this is a good start, though we don't really use those binaries for anything other than debugging. Releases are done using ko, so I would see this change more like this example: https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/2955.

hakman avatar Jul 09 '25 10:07 hakman

@huhouhua I think this is a good start, though we don't really use those binaries for anything other than debugging. Releases are done using ko, so I would see this change more like this example: kubernetes-sigs/aws-load-balancer-controller#2955.

Please confirm, do all the instructions using ko build in the makefile need to be modified

huhouhua avatar Jul 09 '25 10:07 huhouhua

Ah, wait. Let's start with what you have now, but could you limit the changes to the kops binary in this PR? Will try to look deeper later this week. Sorry for the initial confusion.

hakman avatar Jul 09 '25 11:07 hakman

Ah, wait. Let's start with what you have now, but could you limit the changes to the kops binary in this PR? Will try to look deeper later this week. Sorry for the initial confusion.

Don't merge it yet, wait until it's confirmed later this week before modifying it

huhouhua avatar Jul 09 '25 13:07 huhouhua

sure, no worries, need to add some comments for sure.

hakman avatar Jul 09 '25 13:07 hakman

@hakman Is the command definition for kops release in the makefile?

huhouhua avatar Jul 11 '25 08:07 huhouhua

@huhouhua: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-test 38e9a7a2f57f72eed8e74f38e625008925222839 link true /test pull-kops-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jul 13 '25 15:07 k8s-ci-robot

@hakman @justinsb Hi I’d like to follow up on this PR. Please let me know if there’s anything that needs adjustment. Thank you

huhouhua avatar Jul 15 '25 19:07 huhouhua

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 10 '25 23:08 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 09 '25 00:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 09 '25 01:12 k8s-triage-robot