kubernetes
GCE: set node labels and taints as autoscaler env vars
This proposed change sets InstanceGroup node labels and taints in kube-env on GCP, so that autoscaler can make a scale-up decision based on taints and tolerations, and that the resulting node has the labels set.
Hi @flopib. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Thanks @flopib, can you add a test case for this? You can add some example node labels and taints to this instance group, run ./hack/update-expected.sh, and commit all the changes.
The verify-terraform CI failure is from the most recent updates in https://github.com/hashicorp/terraform-provider-aws/issues/43213
Once resolved we can rerun the job
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rifelpet
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rifelpet]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias
In response to this:
/override pull-kops-e2e-k8s-gce-ipalias
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.