kops icon indicating copy to clipboard operation
kops copied to clipboard

Normalize the hardcoded images used for warmpool pre-pulling

Open rifelpet opened this issue 1 year ago • 7 comments

Fixes https://github.com/kubernetes/kops/issues/16871

When AWS WarmPool is enabled, nodeup pre-pulls a hardcoded list of images based on the cluster's assets:

https://github.com/rifelpet/kops/blob/4a882890ff2addb1ae0f69f93280102969ab64d3/pkg/nodemodel/nodeupconfigbuilder.go#L490-L507

When a cluster has:

spec:
  assets:
    containerProxy: public.ecr.aws/1234

All of the assets are remapped to begin with the containerProxy value. This results in the WarmPool logic not matching against any of the cluster's assets, and nodeup doesn't treat the instance as being in the warm pool.

Now we run the hardcoded images through the same remapping logic to ensure its matched against any images used in the cluster's assets.

rifelpet avatar Dec 17 '24 05:12 rifelpet

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Dec 17 '24 05:12 k8s-ci-robot

/hold for manual testing with the e2e job's KOPS_BASE_URL.

rifelpet avatar Dec 17 '24 05:12 rifelpet

@rifelpet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-flannel a01e7b806b94881c0300d745349d3ee3254f72b6 link true /test pull-kops-e2e-cni-flannel
pull-kops-e2e-gce-cni-calico a01e7b806b94881c0300d745349d3ee3254f72b6 link true /test pull-kops-e2e-gce-cni-calico
pull-kops-e2e-gce-cni-kindnet a01e7b806b94881c0300d745349d3ee3254f72b6 link true /test pull-kops-e2e-gce-cni-kindnet
pull-kops-e2e-k8s-aws-amazonvpc-u2404 a01e7b806b94881c0300d745349d3ee3254f72b6 link true /test pull-kops-e2e-k8s-aws-amazonvpc-u2404

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jan 20 '25 02:01 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 20 '25 03:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 20 '25 04:05 k8s-triage-robot

/retest

rifelpet avatar Jun 12 '25 02:06 rifelpet

/remove-lifecycle rotten

hakman avatar Jul 04 '25 12:07 hakman

@rifelpet anything left to do here?

hakman avatar Jul 04 '25 12:07 hakman

@rifelpet anything left to do here?

@hakman this should be ready for review

rifelpet avatar Jul 16 '25 03:07 rifelpet

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 16 '25 03:07 k8s-ci-robot

/retest /hold cancel

rifelpet avatar Jul 16 '25 10:07 rifelpet