Normalize the hardcoded images used for warmpool pre-pulling
Fixes https://github.com/kubernetes/kops/issues/16871
When AWS WarmPool is enabled, nodeup pre-pulls a hardcoded list of images based on the cluster's assets:
https://github.com/rifelpet/kops/blob/4a882890ff2addb1ae0f69f93280102969ab64d3/pkg/nodemodel/nodeupconfigbuilder.go#L490-L507
When a cluster has:
spec:
assets:
containerProxy: public.ecr.aws/1234
All of the assets are remapped to begin with the containerProxy value. This results in the WarmPool logic not matching against any of the cluster's assets, and nodeup doesn't treat the instance as being in the warm pool.
Now we run the hardcoded images through the same remapping logic to ensure its matched against any images used in the cluster's assets.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/hold for manual testing with the e2e job's KOPS_BASE_URL.
@rifelpet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kops-e2e-cni-flannel | a01e7b806b94881c0300d745349d3ee3254f72b6 | link | true | /test pull-kops-e2e-cni-flannel |
| pull-kops-e2e-gce-cni-calico | a01e7b806b94881c0300d745349d3ee3254f72b6 | link | true | /test pull-kops-e2e-gce-cni-calico |
| pull-kops-e2e-gce-cni-kindnet | a01e7b806b94881c0300d745349d3ee3254f72b6 | link | true | /test pull-kops-e2e-gce-cni-kindnet |
| pull-kops-e2e-k8s-aws-amazonvpc-u2404 | a01e7b806b94881c0300d745349d3ee3254f72b6 | link | true | /test pull-kops-e2e-k8s-aws-amazonvpc-u2404 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
/retest
/remove-lifecycle rotten
@rifelpet anything left to do here?
@rifelpet anything left to do here?
@hakman this should be ready for review
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hakman
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hakman]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest /hold cancel