kops icon indicating copy to clipboard operation
kops copied to clipboard

[ROOT VOLUME] Missing labels on root volumes on Nodes

Open dannyeuu opened this issue 1 year ago • 6 comments

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see. On our FINOPS reports, the EBS of root volumes on all nodes is missing labels. The EBS of CSIs has labels right, but the root does not. We use kOps on AWS with SpotInst.

2. Feel free to provide a design supporting your feature request. Apply the same nodelabels to root volume, and add a feature like rootvolumelabels on instance groups to add others labels

dannyeuu avatar Oct 18 '24 15:10 dannyeuu

FYI @yehielnetapp

hakman avatar Nov 04 '24 10:11 hakman

If I understand you correctly, cloudLabels will do what you are missing:

apiVersion: kops.k8s.io/v1alpha2
kind: InstanceGroup
metadata:
  labels:
    kops.k8s.io/cluster: k8s.our.cluster.name
  name: control-plane-aws-region-1
spec:
  cloudLabels:
    Environment: production
    Role: k8s
    Something: else
  role: Master
  other: values-here

This will add Environment/Role/Something tags to the instance and its volumes for this instancegroup, including even etcd's EBS volumes.

vitaliyf avatar Nov 26 '24 17:11 vitaliyf

Hi @vitaliyf I have the cloud labels ,everything has the correct labels, Except the ROOT-EBS.

dannyeuu avatar Nov 26 '24 22:11 dannyeuu

Hm, I just double-checked and what I posted above seems to work for us - the root EBS volumes for all our instance groups have those additional cloud labels on them.

Image

vitaliyf avatar Feb 01 '25 22:02 vitaliyf

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 02 '25 23:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 02 '25 00:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jul 02 '25 01:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 02 '25 01:07 k8s-ci-robot