kops icon indicating copy to clipboard operation
kops copied to clipboard
verified publisher icon kubernetes

WIP: Use MethodByName only with constants

Open justinsb opened this issue 1 year ago • 11 comments

We would like to enable dead-code-elimination, as unblocked by https://go-review.googlesource.com/c/go/+/522436

justinsb avatar Aug 04 '24 19:08 justinsb

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 14 '24 02:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 20 '25 02:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 27 '25 22:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Jun 26 '25 22:06 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 26 '25 22:06 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rifelpet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 27 '25 03:06 k8s-ci-robot

/remove-lifecycle stale

hakman avatar Jun 27 '25 03:06 hakman

/remove-lifecycle rotten

hakman avatar Jun 27 '25 03:06 hakman

@justinsb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-flannel 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-cni-flannel
pull-kops-e2e-gce-cni-calico 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-gce-cni-calico
pull-kops-e2e-gce-cni-cilium 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-gce-cni-cilium
pull-kops-e2e-gce-cni-kindnet 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-gce-cni-kindnet
pull-kops-e2e-k8s-aws-amazonvpc-u2404 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-k8s-aws-amazonvpc-u2404
pull-kops-e2e-k8s-gce-cilium 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-k8s-gce-ipalias 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-k8s-gce-ipalias
pull-kops-e2e-k8s-aws-amazonvpc 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-k8s-aws-amazonvpc
pull-kops-e2e-k8s-aws-calico 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-e2e-k8s-aws-calico
pull-kops-verify-boilerplate 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-verify-boilerplate
pull-kops-build 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-build
pull-kops-verify-govet 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-verify-govet
pull-kops-test 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-test
pull-kops-verify-gofmt 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-verify-gofmt
pull-kops-verify-gomod 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-verify-gomod
pull-kops-verify-golangci-lint 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-verify-golangci-lint
pull-kops-verify-generated 1c44642414886beedd7a5f4caebdb8b19e924e0d link true /test pull-kops-verify-generated

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jun 27 '25 03:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 25 '25 04:09 k8s-triage-robot

/remove-lifecycle stale

hakman avatar Sep 25 '25 04:09 hakman