kops icon indicating copy to clipboard operation
kops copied to clipboard

Bump nvidia-driver-535 for CUDA 12 support

Open ddelange opened this issue 1 year ago • 8 comments

Close https://github.com/kubernetes/kops/issues/16557

ddelange avatar May 10 '24 13:05 ddelange

Hi @ddelange. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 10 '24 13:05 k8s-ci-robot

/ok-to-test

hakman avatar May 11 '24 02:05 hakman

@ddelange Please squash the commits and add a description, including why the switch from headless to driver.

@olemarkus Any thoughts about this?

hakman avatar May 16 '24 15:05 hakman

/cc @olemarkus

hakman avatar May 16 '24 15:05 hakman

Definitely use the -server package, which does not bring in the xorg-core deps.

olemarkus avatar May 16 '24 19:05 olemarkus

@ddelange would you like to continue with this PR? 😄

hakman avatar May 31 '24 16:05 hakman

hey :wave: I'm AFK until beginning July. Feel free to take over if you have the time:)

ddelange avatar Jun 18 '24 15:06 ddelange

/test all

hakman avatar Sep 07 '24 15:09 hakman

@hakman ready to merge?

ddelange avatar Oct 15 '24 07:10 ddelange

Thanks @ddelange. Would you mind also squashing the commits?

hakman avatar Oct 15 '24 07:10 hakman

done :)

ddelange avatar Oct 15 '24 08:10 ddelange

@ddelange: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-aws-calico-k8s-infra b6e0745a0a90bf634684259b0012ebe41a7efb75 link true /test pull-kops-e2e-k8s-aws-calico-k8s-infra

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Oct 15 '24 08:10 k8s-ci-robot

Thanks! /lgtm /approve

hakman avatar Oct 15 '24 09:10 hakman

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 15 '24 09:10 k8s-ci-robot

/test pull-kops-verify-terraform

hakman avatar Oct 15 '24 09:10 hakman