kops
kops copied to clipboard
kubernetes
[WIP] hetzner: Cluster without DNS or Gossip
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman by writing /assign @hakman in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@hakman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kops-test | 8890b46dbd4b655fbb84cc0c4810f9ae17d4e9c0 | link | true | /test pull-kops-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
If I understand this PR correctly, it tries to make empty master internal name allowed. That will break a few addons that must run before the kuberntes.default service exists. Since the manifests are rendered before LB creation, I am not sure how that will work.
If I understand this PR correctly, it tries to make empty master internal name allowed. That will break a few addons that must run before the
kuberntes.defaultservice exists. Since the manifests are rendered before LB creation, I am not sure how that will work.
Any example of such manifests?
Cilium always requires it. Calico when using BPF mode. Karpenter also references it, but not sure its strictly required anymore.
Easiest way to go about this would be to add a new entry in /etc/hosts on each node.
Though, this won't work for LBs with stable DNS name only, like in AWS. At least I'm not sure that the internal IP is stable.
