kops
kops copied to clipboard
kubernetes
Create etcd-manager config for each instance group
kOps should give a way for etcd-manager to identify a specific volume for a specific control-plane node. This means having access to the instance group, as defined in the cluster config:
https://github.com/kubernetes/kops/blob/70c85280917f67c9c057ec41e31ee148bd5333c1/pkg/apis/kops/cluster.go#L664-L665
This can be done either directly in etcd-manager, by having some hardcoded tags, or by passing a specific config for each instance group, which includes the instance group tag. My preference is for the latter.
Looks good. You are only using IG-specific tags for hetzner now, right? nothing changes for AWS?
Looks good. You are only using IG-specific tags for hetzner now, right? nothing changes for AWS?
Yes, only Hetzner and flag is still up to debate.
Thanks @hakman this lgtm, and will help us be more precise with rolling updates etc. I now also understand better why you want to try to keep instance groups to a specific member - that makes a lot more sense now that I see it!
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [justinsb]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [justinsb]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment