kops
kops copied to clipboard
kubernetes
WIP: Expose channels through kops cli
Mount the channels API on kops addons. I put everything under addons rather than reusing kops get etc since especially apply have very different semantics.
Still some work left. In particular getting default cluster name, state store etc. Should try to merge the two CLI factories in some way.
/kind office-hours
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from olemarkus by writing /assign @olemarkus in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Meant to comment on this during office hours; I think having get is good here. Apply we might not want to encourage users to use, so I proposed we put that command under toolbox, so we make fewer guarantees about it etc
@olemarkus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kops-verify-boilerplate | 8708f63fd08a0540c4c86139b62526979d6a0e0f | link | true | /test pull-kops-verify-boilerplate |
| pull-kops-e2e-k8s-gce-cilium | 8708f63fd08a0540c4c86139b62526979d6a0e0f | link | true | /test pull-kops-e2e-k8s-gce-cilium |
| pull-kops-e2e-aws-karpenter | 8708f63fd08a0540c4c86139b62526979d6a0e0f | link | true | /test pull-kops-e2e-aws-karpenter |
| pull-kops-e2e-k8s-aws-calico | 8708f63fd08a0540c4c86139b62526979d6a0e0f | link | true | /test pull-kops-e2e-k8s-aws-calico |
| pull-kops-test | 8708f63fd08a0540c4c86139b62526979d6a0e0f | link | true | /test pull-kops-test |
| pull-kops-build | 8708f63fd08a0540c4c86139b62526979d6a0e0f | link | true | /test pull-kops-build |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
This came up in office hours, are we agreed that it should go under toolbox? And is this still important?
I think this is still important. It's always annoying to tell people they have to log into a control plane node and look at protokube logs in order to determine if channels did something wrong.
@olemarkus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kops-e2e-aws-karpenter | 8708f63fd08a0540c4c86139b62526979d6a0e0f | link | true | /test pull-kops-e2e-aws-karpenter |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hakman
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hakman]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment