kops icon indicating copy to clipboard operation
kops copied to clipboard

chore: Enable codeql action

Open naveensrinivasan opened this issue 3 years ago • 3 comments

This action runs GitHub's industry-leading semantic code analysis engine, CodeQL, against a repository's source code to find security vulnerabilities.

https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning-with-codeql

https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast Signed-off-by: naveen [email protected]

naveensrinivasan avatar Jun 02 '22 23:06 naveensrinivasan

Hi @naveensrinivasan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 02 '22 23:06 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign geojaz after the PR has been reviewed. You can assign the PR to them by writing /assign @geojaz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 02 '22 23:06 k8s-ci-robot

/kind office-hours

olemarkus avatar Jun 03 '22 05:06 olemarkus

Thanks @naveensrinivasan, but I don't think CodeQL is ready for such a large code base at the moment. It takes a very long time to run and fails without a clear reason. It also doesn't allow to skip the vendor/ dir. We may revisit this in the future.

hakman avatar Sep 02 '22 10:09 hakman