kops icon indicating copy to clipboard operation
kops copied to clipboard
verified publisher icon kubernetes

Use KUBETEST2_RUN_DIR for binaries if set

Open nckturner opened this issue 3 years ago • 9 comments

  • Allow the environment variable KUBETEST2_RUN_DIR to be used for expected binary locations.
  • If set, it is set as the runDir in the execute() method. This is similar to what the ginkgo tester does in its Execute() method, which we don't use (ref).
  • This makes it easier to use --use-built-binaries in the ginkgo kubetest2 tester.
  • This requires a change to kubetest2 to allow us to set runDir via a new SetRunDir() method (see https://github.com/kubernetes-sigs/kubetest2/pull/182)

nckturner avatar Feb 07 '22 21:02 nckturner

/hold

nckturner avatar Feb 07 '22 21:02 nckturner

Strangely I'm getting a "security error" when running make gomod due to a checksum mismatch:

verifying github.com/bazelbuild/[email protected]: checksum mismatch
	downloaded: h1:NOx8p+vDJ24UiQ1kG8zMqRLdi/sOBgqld3mXMKAp5HY=
	go.sum:     h1:2EWA2lRrt/k8B5ASt0mlTDQ+7mnzvKdF6ShNWLbk0o0=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.
Makefile:351: recipe for target 'gomod' failed
make: *** [gomod] Error 1

Haven't looked into it yet.

nckturner avatar Feb 08 '22 19:02 nckturner

I'm not sure what the hash mismatch is about but I forgot youll also need to run go mod clean in the tests/e2e directory to keep the verify-gomod prow job happy

rifelpet avatar Feb 08 '22 23:02 rifelpet

I bumped kubetest2 in kops earlier today. If you rebase, you may find the tests passing.

olemarkus avatar Mar 02 '22 18:03 olemarkus

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 30 '22 07:07 k8s-triage-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval by writing /assign @justinsb in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 22 '22 20:08 k8s-ci-robot

/remove-lifecycle stale

nckturner avatar Aug 22 '22 20:08 nckturner

@nckturner: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 28 '22 17:08 k8s-ci-robot

@nckturner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-weave 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-weave
pull-kops-e2e-cni-cilium 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-cilium
pull-kops-e2e-cni-flannel 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-flannel
pull-kops-e2e-cni-kuberouter 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-kuberouter
pull-kops-e2e-cni-calico-ipv6 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-calico-ipv6
pull-kops-e2e-cni-amazonvpc 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-amazonvpc
pull-kops-e2e-cni-calico 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-calico
pull-kops-e2e-aws-karpenter fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-e2e-aws-karpenter
pull-kops-test fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-test
pull-kops-build fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Aug 31 '22 07:08 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 29 '22 08:11 k8s-triage-robot

@nckturner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-weave 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-weave
pull-kops-e2e-cni-cilium 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-cilium
pull-kops-e2e-cni-flannel 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-flannel
pull-kops-e2e-cni-kuberouter 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-kuberouter
pull-kops-e2e-cni-calico-ipv6 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-calico-ipv6
pull-kops-e2e-cni-amazonvpc 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-amazonvpc
pull-kops-e2e-cni-calico 55cd03ac66ec26a9c93782714aa8eeda3bd32e06 link true /test pull-kops-e2e-cni-calico
pull-kops-e2e-aws-karpenter fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-e2e-aws-karpenter
pull-kops-test fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-test
pull-kops-build fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-build
pull-kops-e2e-cni-cilium-etcd fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-e2e-cni-cilium-etcd
pull-kops-e2e-cni-cilium-eni fc0594e5ab556cc785464b042a98976e74f01fe2 link true /test pull-kops-e2e-cni-cilium-eni

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Dec 07 '22 19:12 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 06 '23 20:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Feb 05 '23 21:02 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 05 '23 21:02 k8s-ci-robot