kops WIP Stop feature-flagging SpecOverride

We turn it into an unchecked default-on feature flag because the e2e upgrade tests use it.

May 30 '21 23:05 johngmyers

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from johngmyers after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

May 30 '21 23:05 k8s-ci-robot

I don't know who need to approve this. But I agree with this change.

/lgtm

May 31 '21 12:05 olemarkus

@johngmyers https://github.com/kubernetes/kops/pull/9840#issuecomment-684869619 were some thoughts when we last discussed about this during office hours.

Jun 07 '21 14:06 hakman

@johngmyers: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jun 14 '21 17:06 k8s-ci-robot

I think the only thing remaining is documenting how to set multiple array elements, like:

--set=cluster.spec.kubeDNS.upstreamNameservers=2620:119:53::35
--set=cluster.spec.kubeDNS.upstreamNameservers=2620:119:53::53

Setting map elements should also be possible in the future but we should create an issue and document it as a limitation:

--set=cluster.spec.cloudLabels=app=test
...
cannot set field "spec.cloudLabels": unhandled type "map[string]string"

Jun 28 '21 18:06 hakman

/lgtm

Jun 28 '21 18:06 hakman

I think we want to have a release before removing the feature flag.

Jun 28 '21 20:06 johngmyers

Does --set=cluster.spec.cloudLabels.app=test work?

Jun 28 '21 20:06 johngmyers

Does --set=cluster.spec.cloudLabels.app=test work?

No, it triggers an error.

field spec.cloudLabels.app not found in *Cluster

Jun 28 '21 20:06 hakman

Office Hours result: call for review of current syntax.

Jul 04 '21 02:07 johngmyers

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Feb 26 '22 08:02 k8s-triage-robot

/remove-lifecycle stale

Feb 26 '22 08:02 hakman

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jul 30 '22 07:07 k8s-triage-robot

@johngmyers: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-e2e-cni-canal	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-canal`
pull-kops-e2e-cni-cilium-ipv6	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-cilium-ipv6`
pull-kops-e2e-cni-weave	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-weave`
pull-kops-e2e-cni-amazonvpc	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-amazonvpc`
pull-kops-e2e-cni-calico	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-calico`
pull-kops-e2e-cni-calico-ipv6	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-calico-ipv6`
pull-kops-e2e-cni-cilium	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-cilium`
pull-kops-e2e-cni-flannel	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-flannel`
pull-kops-e2e-cni-kuberouter	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-cni-kuberouter`
pull-kops-e2e-k8s-gce-cilium	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-k8s-gce-cilium`
pull-kops-e2e-aws-karpenter	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-aws-karpenter`
pull-kops-e2e-k8s-aws-calico	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-e2e-k8s-aws-calico`
pull-kops-build	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-build`
pull-kops-test	def937d2ae0f52a6d14437f1cf9ca49b841e4cd3	link	true	`/test pull-kops-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Aug 31 '22 07:08 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Sep 30 '22 08:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Oct 30 '22 08:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Oct 30 '22 08:10 k8s-ci-robot