kops icon indicating copy to clipboard operation
kops copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Implement WarmPool on Terraform

Open johngmyers opened this issue 3 years ago • 9 comments

1. Describe IN DETAIL the feature/behavior/change you would like to see.

Implement WarmPool.RenderTerraform()

2. Feel free to provide a design supporting your feature request.

/kind feature /area terraform /lifecycle frozen

johngmyers avatar May 30 '21 19:05 johngmyers

I am new to this project and would love to help in implementing this feature. Can you guide me a little? @johngmyers

Patil2099 avatar May 31 '21 15:05 Patil2099

The task is to implement WarmPool.RenderTerraform.

I would suggest looking at other RenderTerraform receivers to see how they work. You'll need to create an annotated struct corresponding to the Terraform configuration syntax.

Adding an integration test for warmpool would also be good. The integration tests are in kops/cmd/kops/integration_test.go.

johngmyers avatar May 31 '21 16:05 johngmyers

It looks like Terraform puts this inside the ASG definition, so you'll probably have to put this in AutoscalingGroup.RenderTerraform instead.

johngmyers avatar May 31 '21 17:05 johngmyers

/assign

sandeeppainuly avatar May 31 '21 19:05 sandeeppainuly

/assign

vnzongzna avatar Jun 14 '21 19:06 vnzongzna

If others are not working on the task I'd like to look into it now, so am assigning myself.

JacekDuszenko avatar Jun 27 '21 20:06 JacekDuszenko

/assign @JacekDuszenko

JacekDuszenko avatar Jun 27 '21 20:06 JacekDuszenko

The WarmPool task has an AutoScalingGroup reference field yet doesn't use it in any of its methods, I'm assuming this is for dependency purposes @olemarkus ? We likely can't add a WarmPool task reference in the ASG task because of the dependency loop, so we may need to wait for https://github.com/hashicorp/terraform-provider-aws/issues/19229 unless anyone has other ideas on how this could be implemented.

rifelpet avatar Jul 27 '21 21:07 rifelpet

I believe for the Terraform target, the WarmPool task would do nothing. AutoscalingGroupModelBuilder would put the warmpool config into both the WarmPool and AutoscalingGroup tasks.

The trick would then be to keep the warmpool config in the AutoscalingGroup task from showing up in dryrun output.

johngmyers avatar Jul 27 '21 22:07 johngmyers

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 31 '22 18:10 k8s-triage-robot

Seems like this PR addressed this issue. /close

SD-13 avatar Oct 27 '23 19:10 SD-13

@SD-13: Closing this issue.

In response to this:

Seems like this PR addressed this issue. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 27 '23 19:10 k8s-ci-robot