kops icon indicating copy to clipboard operation
kops copied to clipboard

RenderAWS issues with removing substructs

Open johngmyers opened this issue 5 years ago • 6 comments

The design of the changes parameter in RenderAWS leads to latent bugs where RenderAWS is unable to reconcile the removal of a substruct. An example of this is #11255.

It is easy to write code to test whether a subfield of changes is == nil in order to determine whether a change needs to be made. But if the expected is nil and actual is non-nil such naive code will miss that a change is needed.

This is exacerbated because we don't have a framework for methodically unit testing whether RenderAWS receivers are able to reconcile different possible actuals to expecteds.

johngmyers avatar Apr 18 '21 18:04 johngmyers

I think that kops can detect additions and changes of fields, and changes includes them, but deletions are not included. Perhaps, we need to create a new parameter like changes to represent deletions.

h3poteto avatar Apr 19 '21 13:04 h3poteto

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jul 22 '21 16:07 fejta-bot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 21 '21 17:08 k8s-triage-robot

/remove-lifecycle rotten

johngmyers avatar Aug 21 '21 17:08 johngmyers

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 19 '21 18:11 k8s-triage-robot

/remove-lifecycle stale /lifecycle frozen

johngmyers avatar Nov 20 '21 04:11 johngmyers