kompose icon indicating copy to clipboard operation
kompose copied to clipboard

Use format string in log.Fatalf for error messages

Open mahmut-Abi opened this issue 10 months ago • 2 comments

  • Changed log.Fatalf(err.Error()) to log.Fatalf("%s", err.Error())

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

mahmut-Abi avatar Feb 13 '25 06:02 mahmut-Abi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mahmut-Abi Once this PR has been reviewed and has the lgtm label, please assign tessaio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 13 '25 06:02 k8s-ci-robot

log.Fatalf ( “% s ” , err.Error ( ) ) It is better to replace with "log.Fatal". Or complete the newline character "%s\n".

Sorry for the long day. I agree with @LJTian

cdrage avatar Apr 15 '25 15:04 cdrage

Closing for now! Thanks for the PR.

cdrage avatar Jun 24 '25 14:06 cdrage