kompose icon indicating copy to clipboard operation
kompose copied to clipboard
verified publisher icon kubernetes

fix checkIsEmptyDir

Open mcarbonneaux opened this issue 1 year ago • 10 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix bug in recursive checkIsEmptyDir that not work from 1.33.0...

Which issue(s) this PR fixes:

Fixes #1977

mcarbonneaux avatar Dec 18 '24 23:12 mcarbonneaux

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mcarbonneaux / name: CARBONNEAUX Mathieu (ba5480a138b5571751a6fb9c1fa0b3997cf7b625)

linux-foundation-easycla[bot] avatar Dec 18 '24 23:12 linux-foundation-easycla[bot]

Welcome @mcarbonneaux!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Dec 18 '24 23:12 k8s-ci-robot

gofmt also needs to be called too! Thanks for the contribution @mcarbonneaux

cdrage avatar Dec 19 '24 16:12 cdrage

@mcarbonneaux seems like some e2e tests are failing due to your PR. Can you fix them before approving the PR?

TessaIO avatar Dec 21 '24 10:12 TessaIO

i've tryed to fix the test.

mcarbonneaux avatar Dec 22 '24 15:12 mcarbonneaux

any news ?

mcarbonneaux avatar Mar 19 '25 09:03 mcarbonneaux

any news ?

Hi, sorry about the delay.

Can you rebase against master and try again with the tests / see if it works?

cdrage avatar Apr 15 '25 15:04 cdrage

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mcarbonneaux Once this PR has been reviewed and has the lgtm label, please assign tessaio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 14 '25 19:05 k8s-ci-robot

Can you rebase against master and try again with the tests / see if it works?

i've synced the master, but i don't kown how to launch the test.

mcarbonneaux avatar May 14 '25 19:05 mcarbonneaux

i've try make test and i have this error but is seem not related to my commits:

===> Starting test <===
convert::expect_success: Running: 'kompose -f /data/ch2o/k8s/kompose/script/test/fixtures/configmap-file-configs/compose-3.yaml convert --stdout --with-kompose-annotation=false' expected_output: '/data/ch2o/k8s/kompose/script/test/fixtures/configmap-file-configs/output-k8s-3.yaml'
.....
test: "" kind: ConfigMap metadata: labels: io.kompose.service: busy name: busy-cm0 kind: ConfigMap metadata: name: busy-cm0 labels: io.kompose.service: busy spec.template.spec (apps/v1/Deployment/busy) + one map entry added: volumes: - name: busy-cm0 configMap: name: busy-cm0 spec.template.spec.containers.busy (apps/v1/Deployment/busy) + one map entry added: volumeMounts: - name: busy-cm0 mountPath: /tmp readOnly: true
FAIL: converted output does not match
make: *** [Makefile:85: test-cmd] Error 1

the diff of the genereted spec and the espected spec: image

mcarbonneaux avatar May 14 '25 19:05 mcarbonneaux

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 12 '25 21:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 11 '25 22:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Oct 11 '25 22:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 11 '25 22:10 k8s-ci-robot

/reopen

n-rodriguez avatar Oct 11 '25 22:10 n-rodriguez

@n-rodriguez: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 11 '25 22:10 k8s-ci-robot

Facing the same problem, here. I would love to see this reopened.

loderunner avatar Oct 29 '25 15:10 loderunner

kind ping @mcarbonneaux if not, could we open a separate PR from our side with your fix?

cdrage avatar Oct 29 '25 20:10 cdrage

Going to close this PR for now / curating some of our old PR's at the moment.

Please feel free to re-open this after updating!

cdrage avatar Nov 17 '25 19:11 cdrage