kompose icon indicating copy to clipboard operation
kompose copied to clipboard

feat(deploy): support ephemeral storage requests limits labels

Open jvitor83 opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow to use labels in the deploy section to convert to kubernetes resources requests and limits for ephemeral-storage

Which issue(s) this PR fixes:

Fixes #1935

Special notes for your reviewer:

❤️

jvitor83 avatar Sep 27 '24 00:09 jvitor83

Changed and Added tests as asked @cdrage

jvitor83 avatar Oct 03 '24 23:10 jvitor83

So sorry for the delay, but thank you for the changes, this LGTM.

cdrage avatar Oct 30 '24 14:10 cdrage

/lgtm

cdrage avatar Oct 30 '24 14:10 cdrage

/approve

cdrage avatar Oct 30 '24 14:10 cdrage

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, jvitor83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 30 '24 14:10 k8s-ci-robot

Amazing work, big thanks for this new feature!!! 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀

cdrage avatar Oct 30 '24 14:10 cdrage

Fixed the expected label in test, sorry, forgot to rename there before. All good now @cdrage

jvitor83 avatar Oct 31 '24 00:10 jvitor83

/lgtm

cdrage avatar Nov 27 '24 19:11 cdrage