kubernetes
feature: support UID:GID in the user key
What type of PR is this?
/kind feature
What this PR does / why we need it:
With this PR, Kompose can convert UID:GID to both RunAsUser and RunAsGroup. Previously, it cannot understand the :GID part.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I have not created tests for this feature!
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: favonia / name: favonia (0ace11079e3323b180945ba3f7e61b9b0982735e)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @favonia!
It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/kompose has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Sorry for the compilation error. It's now fixed.
Apologize for the delay! I am on PTO. But I'll be happy to test this Tuesday :) pleases remind me if I don't haha! This is a great feature to finally add.
Tested this out and it works great!
LGTM! Once this pasts tests, it'll merge.
Thanks for the awesome contribution!!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cdrage, favonia
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [cdrage]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment