kubernetes
Feature 1635 - customizing service name with prefix, flag --prefix (-x)
What type of PR is this?
/kind feature
What this PR does / why we need it:
The --prefix flag serves the purpose of allowing users to specify prefixes to be added to the names of services
Which issue(s) this PR fixes:
Feature #1635
Special notes for your reviewer:
I haven't had time to document the --prefix flag documentation will be cooming soon in the following commits.
@TessaIO shouldn't we have this as a label instead? or do you think CLI parameter would be fine?
@TessaIO shouldn't we have this as a label instead? or do you think CLI parameter would be fine?
That's actually true if we want to offer users flexibility to specify per-service prefixes that's the option to go (I mean labels here). wdyt @sosan?
@TessaIO shouldn't we have this as a label instead? or do you think CLI parameter would be fine?
That's actually true if we want to offer users flexibility to specify per-service prefixes that's the option to go (I mean labels here). wdyt @sosan?
Yeah just thinking about it again, I think I'm good for terminal / cli based prefixes being added, we could always customize the name individually via labels instead.
Updated cli
Sounds like a good idea to me. That way, we can fine-tune the names individually using labels
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sosan, TessaIO
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [TessaIO]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hey sorry @sosan for some reason I didn't realize that we reached a conclusion on https://github.com/kubernetes/kompose/issues/1635#issuecomment-2031874480 that we should actually close this PR, and I apologize the work you've put into this back and forth.
Going forward I do not think we should be adding too many suffix and prefix / name customizations unless it's "generic", if someone wants to edit the entire -tcp suffix, they could do it with a sed / ctrl +f / ctrl + replace after converting.
There's too much work and labels / parameters to be added to make something small like this happen.