kubernetes
fix daemonset creation (add selector)
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: realgam3 / name: Tomer Zait (06bb4f5279723d2220be37d42970af33c2c86f20)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @realgam3!
It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/kompose has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
A daemonset created with selector=null causes an error when applied:
error: error validating "test-daemonset.yaml": error validating data: ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec; if you choose to ignore these errors, turn validation off with --validate=false
Hi @kadel and @surajssd, Can you review this pull request? It fix an error I encounter lately
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kadel, realgam3
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [kadel]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment